Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review217790 --- Patch looks great! Reviews applied: [64932, 65042] Passed

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/ --- (Updated Sept. 17, 2019, 3 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195183 --- Ship it! Ship It! - Gaston Kleiman On Jan. 10, 2018, 1:16

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195124 --- FAIL: mesos-java failed to build. Reviews applied: `['64932',

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

> On Jan. 9, 2018, 10:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 422-432 (patched) > > > > > > It is not very clear to me why we need this block. > > > > Do we

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/ --- (Updated Jan. 10, 2018, 10:16 a.m.) Review request for mesos, Gaston Kleiman

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195078 --- src/examples/test_csi_user_framework.cpp Line 93 (original), 91

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195061 --- PASS: Mesos patch 65042 was successfully built and tested.

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

> On Jan. 9, 2018, 6:14 p.m., Till Toenshoff wrote: > > src/examples/test_csi_user_framework.cpp > > Line 432 (original), 428 (patched) > > > > > > Used the wrong constructor here - this won't authenticate. Even

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/ --- (Updated Jan. 9, 2018, 7:01 p.m.) Review request for mesos, Gaston Kleiman and

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195044 --- src/examples/test_csi_user_framework.cpp Line 94 (original), 96

Re: Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195028 --- PASS: Mesos patch 65042 was successfully built and tested.

Review Request 65042: Adjusted CSI example framework for recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/ --- Review request for mesos, Gaston Kleiman and Till Toenshoff. Repository: mesos