Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Feb. 19, 2018, 12:08 p.m.) Review request for mesos, Benjamin

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review197672 --- Fix it, then Ship it! src/slave/http.cpp Lines 1695 (patched)

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Feb. 15, 2018, 11:19 a.m.) Review request for mesos, Benjamin

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 26, 2018, 10:20 p.m., Vinod Kone wrote: > > src/slave/http.cpp > > Lines 1685 (patched) > > > > > > Not yours, but can we make the logging consistent here and in master > > for operator api handlers?

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Feb. 1, 2018, 7:46 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 6349-6352 (patched) > > > > > > Are these necessary? I think that framework registration may be > > sufficient to produce an

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Feb. 6, 2018, 11:10 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Feb. 1, 2018, 7:46 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 6280 (patched) > > > > > > Could you leave a comment here saying that we do this simply to make it > > easier to handle resource

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Feb. 1, 2018, 7:46 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 6349-6352 (patched) > > > > > > Are these necessary? I think that framework registration may be > > sufficient to produce an

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196620 --- Looks great, thanks Jan! I left some comments below on the agent

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 26, 2018, 9:20 p.m., Vinod Kone wrote: > > src/slave/http.cpp > > Lines 1685 (patched) > > > > > > Not yours, but can we make the logging consistent here and in master > > for operator api handlers?

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196370 --- API changes look good to me. I haven't reviewed the tests though.

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 25, 2018, 11:36 a.m.) Review request for mesos, Benjamin

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 24, 2018, 8:17 p.m., Gaston Kleiman wrote: > > src/master/http.cpp > > Line 3933 (original), 3961 (patched) > > > > > > Shouldn't we add a similar method: `Master:Http:OPERATIONS_HELP()`?

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196152 --- src/master/http.cpp Lines 741-742 (patched)

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 24, 2018, 10:36 a.m.) Review request for mesos, Benjamin

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196061 --- src/tests/api_tests.cpp Lines 6376-6379 (patched)

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 22, 2018, 7:37 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Lines 1011 (patched) > > > > > > Let's mention here that this is 5s. Solved this otherwise, no longer changing the allocation

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 23, 2018, 1:14 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 22, 2018, 8:51 p.m., Gaston Kleiman wrote: > > src/tests/api_tests.cpp > > Lines 1011-1013 (patched) > > > > > > This doesn't seem to be necessary in most other tests, why exaclty do > > we need it here?

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 22, 2018, 8:51 p.m., Gaston Kleiman wrote: > > src/tests/api_tests.cpp > > Lines 1011-1013 (patched) > > > > > > This doesn't seem to be necessary in most other tests, why exaclty do > > we need it here?

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195927 --- src/tests/api_tests.cpp Lines 1011-1013 (patched)

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review195914 --- include/mesos/agent/agent.proto Lines 72 (patched)

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 17, 2018, 10:18 a.m., Benjamin Bannier wrote: > > src/common/protobuf_utils.cpp > > Lines 1288-1290 (patched) > > > > > > Once we have settled where to transport this information we should > > create a

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 22, 2018, 3:02 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 19, 2018, 2:37 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

> On Jan. 17, 2018, 10:18 a.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 181 (original), 181 (patched) > > > > > > Could you add something to the commit message explaining why this is > >

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Jan. 18, 2018, 3:10 p.m.) Review request for mesos, Benjamin Bannier,