Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 14, 2018, 5:49 p.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 304 (patched) > > > > > > This case means `docker stop` is in progress (`killed == true`): > >

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197567 --- src/docker/executor.cpp Lines 304 (patched)

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197395 --- Patch looks great! Reviews applied: [65518] Passed command:

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197376 --- PASS: Mesos patch 65518 was successfully built and tested.

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/ --- (Updated Feb. 13, 2018, 11:20 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 10, 2018, 2:21 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 273-302 (patched) > > > > > > Could we validate this with a test? I think it would be possible to use > > a `MockDocker` which

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197242 --- Patch looks great! Reviews applied: [65518] Passed command:

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197241 --- PASS: Mesos patch 65518 was successfully built and tested.

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/ --- (Updated Feb. 12, 2018, 11:46 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 10, 2018, 8:55 a.m., Vinod Kone wrote: > > src/docker/executor.cpp > > Lines 277 (patched) > > > > > > s/never returns though/to never return although/ I see Greg suggests to change `returns` to

Re: Review Request 65518: Reaped the container process directly in Docker executor.

> On Feb. 10, 2018, 10:21 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 273-302 (patched) > > > > > > Could we validate this with a test? I think it would be possible to use > > a `MockDocker` which

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197203 --- src/docker/executor.cpp Lines 273-302 (patched)

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197206 --- src/docker/executor.cpp Lines 277 (patched)

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197164 --- Patch looks great! Reviews applied: [65518] Passed command:

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197141 --- Ship it! Ship It! - Gaston Kleiman On Feb. 8, 2018, 5:03

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review196893 --- PASS: Mesos patch 65518 was successfully built and tested.

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/ --- (Updated Feb. 6, 2018, 9:45 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review196862 --- PASS: Mesos patch 65518 was successfully built and tested.

Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-8488