Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-06-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/#review204997 --- Ship it! Ship It! - Benjamin Bannier On June 18, 2018, 8:31

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-06-18 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated June 18, 2018, 6:31 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-06-13 Thread Chun-Hung Hsiao
> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote: > > LGTM, but I wonder whether it would make sense to keep the assertions and > > reject outdated resources more generally based on e.g., resource versions. > > Chun-Hung Hsiao wrote: > Hmm good point. I thought about it a bit. >

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-06-13 Thread Chun-Hung Hsiao
> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote: > > LGTM, but I wonder whether it would make sense to keep the assertions and > > reject outdated resources more generally based on e.g., resource versions. Hmm good point. I thought about it a bit. I changed these assertions for accepted

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-06-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated June 14, 2018, 12:07 a.m.) Review request for mesos, Benjamin

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/#review201631 --- LGTM, but I wonder whether it would make sense to keep the

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated April 12, 2018, 3:37 a.m.) Review request for mesos, Benjamin

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-03-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated March 20, 2018, 3:21 a.m.) Review request for mesos, Benjamin

Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

2018-03-07 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu. Bugs: