Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-05-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review202212 --- Patch looks great! Reviews applied: [66258, 66591, 66259, 66260,

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-05-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review202203 --- PASS: Mesos patch 66293 was successfully built and tested.

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-05-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/ --- (Updated May 1, 2018, 9:43 a.m.) Review request for mesos, Jason Lai and James

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review202160 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review201819 --- Patch looks great! Reviews applied: [66481, 66258, 66591, 66259,

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review201813 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review201085 --- Patch looks great! Reviews applied: [66481, 66258, 66591, 66259,

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review201051 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review200720 --- Patch looks great! Reviews applied: [66481, 66258, 66259, 66260,

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review200714 --- PASS: Mesos patch 66293 was successfully built and tested.

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

2018-04-07 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/ --- (Updated April 7, 2018, 5:54 p.m.) Review request for mesos, Jason Lai and