Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201874 --- src/tests/resource_provider_manager_tests.cpp Line 823

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201603 --- Ship it! Ship It! - Chun-Hung Hsiao On April 19, 2018, 9:19

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

> On April 18, 2018, 9:31 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.hpp > > Lines 71-73 (original), 73-75 (patched) > > > > > > I was wondering that, since we have a generic storage-backed

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

> On April 18, 2018, 11:31 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.hpp > > Line 69 (original), 71 (patched) > > > > > > Does it make sense to use `process::Owned&& storage`? I don't think

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

> On April 19, 2018, 12:19 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.hpp > > Line 113 (original), 114 (patched) > > > > > > `process::Owned&& storage`? See above. > On April 19, 2018, 12:19

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

> On April 18, 2018, 11:51 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.hpp > > Lines 67-73 (original), 69-75 (patched) > > > > > > Not yours, but if each `create()` corresponds to a different

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/ --- (Updated April 19, 2018, 11:19 a.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201476 --- src/resource_provider/registrar.hpp Line 113 (original), 114

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

> On April 18, 2018, 9:51 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/registrar.hpp > > Lines 67-73 (original), 69-75 (patched) > > > > > > Not yours, but if each `create()` corresponds to a different type

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201469 --- src/resource_provider/registrar.hpp Lines 67-73 (original),

Re: Review Request 66309: Externalized creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/#review201449 --- src/resource_provider/registrar.hpp Line 67 (original), 69