Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200572 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:46

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

2018-04-04 Thread Andrew Schwartzmeyer
> On April 4, 2018, 3:12 p.m., John Kordich wrote: > > 3rdparty/stout/include/stout/os/windows/jobobject.hpp > > Lines 139 (patched) > > > > > > This is interesting. I understand how you're using this template > >

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200503 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:46

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200502 --- Fix it, then Ship it! Oops. I just realized as I was getting

Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

2018-04-03 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and