Re: Review Request 66545: Added admitted resource providers to the manager's registry.

> On April 25, 2018, 1:50 a.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Line 851 (original), 851 (patched) > > > > > > Should we add a new test for `GenericRegistrar` recovery?

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review201878 --- src/tests/resource_provider_manager_tests.cpp Line 851

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review201871 --- Ship it! Ship It! - Chun-Hung Hsiao On April 23, 2018,

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

> On April 23, 2018, 9:30 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 685 (patched) > > > > > > Let's move the actual logic from r/66546 to this patch to make it > > self-contained.

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

> On April 23, 2018, 11:30 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 685 (patched) > > > > > > Let's move the actual logic from r/66546 to this patch to make it > >

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review201766 --- src/resource_provider/manager.cpp Lines 685 (patched)

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/ --- (Updated April 23, 2018, 1:19 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

> On April 11, 2018, 2:47 p.m., Jan Schlicht wrote: > > src/resource_provider/manager.cpp > > Lines 668 (patched) > > > > > > Shouldn't this be `false` here? If there's no registrar to admit a > > resource provider

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/ --- (Updated April 12, 2018, 11:48 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/ --- (Updated April 12, 2018, 11:16 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/#review200903 --- src/resource_provider/manager.cpp Lines 668 (patched)

Review Request 66545: Added admitted resource providers to the manager's registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66545/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht. Bugs: