Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- (Updated May 1, 2018, 2:23 p.m.) Review request for mesos, Akash Gupta, John

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

> On May 1, 2018, 12:16 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/permissions.hpp > > Lines 64 (patched) > > > > > > I have a feeling this will pollute the logs unless you demote it to > > `VLOG(2)`

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review202206 --- Fix it, then Ship it!

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- (Updated April 30, 2018, 1:52 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

> On April 30, 2018, 11:38 a.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/stat.hpp > > Lines 186 (patched) > > > > > > the comment should be `x / (10 * 1000 * 1000)` :) > > Andrew

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review202132 --- Fix it, then Ship it!

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review202085 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:21

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- (Updated April 26, 2018, 9:21 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review201852 --- Patch looks great! Reviews applied: [66420, 66421, 66422, 66423,

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review201850 --- PASS: Mesos patch 66773 was successfully built and tested.

Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. Bugs: