Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-07-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated July 10, 2018, 3:40 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-07-06 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review205817 --- Fix it, then Ship it! src/master/master.hpp Lines 2974

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-07-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review205813 --- Ship it! Ship It! - Greg Mann On June 27, 2018, 7:34 a.m.,

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated June 27, 2018, 12:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-05-16 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review203264 --- src/master/master.hpp Lines 2993 (patched)

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-05-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated May 15, 2018, 5:33 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-05-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated May 15, 2018, 5:31 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-05-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review203073 --- src/master/metrics.hpp Lines 221 (patched)

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-05-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated May 11, 2018, 12:20 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-05-08 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review202662 --- src/master/metrics.hpp Lines 219-221 (patched)

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

2018-04-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/ --- (Updated April 27, 2018, 11:39 a.m.) Review request for mesos, Benjamin