Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202239 --- Ship it! Ship It! - Joseph Wu On May 1, 2018, 3:43 p.m.,

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/ --- (Updated May 1, 2018, 3:43 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Andrew Schwartzmeyer
> On May 1, 2018, 2:48 p.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/flags/parse.hpp > > Lines 197-200 (patched) > > > > > > There should be a check for exactly 2 tokens here. Instead of using > > the

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-05-01 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202226 --- 3rdparty/stout/include/stout/flags/parse.hpp Lines 197-200

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-04-30 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202135 --- Ship it! Ship It! - Akash Gupta On April 27, 2018, 4:22

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-04-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202086 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:22

Review Request 66834: Windows: Specialized `flags::parse`.

2018-04-26 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.