Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 2:16 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 2:14 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202306 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp Li

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 12:01 p.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

> On May 1, 2018, 7:18 p.m., Chun-Hung Hsiao wrote: > > src/tests/master_validation_tests.cpp > > Lines 1657 (patched) > > > > > > Hmm... we don't have this check when validating `GrowVolume` because we > > are cou

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- (Updated May 2, 2018, 10:24 a.m.) Review request for mesos, Chun-Hung Hsiao and

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202261 --- Bad patch! Reviews applied: [66858, 66227, 66051, 66052, 66532, 6

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202253 --- How about adding tests to validate that resources with providers a

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202251 --- src/tests/master_validation_tests.cpp Lines 1497 (patched)

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202245 --- FAIL: Failed to apply the dependent review: 66531. Failed command

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/#review202099 --- PASS: Mesos patch 66858 was successfully built and tested. Review

Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66858/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-4945 h