Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review204481 --- Ship it! Ship It! - Benjamin Bannier On June 8, 2018, 3:21

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/ --- (Updated June 8, 2018, 1:21 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

> On May 25, 2018, 3:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/grpc.cpp > > Lines 70 (patched) > > > > > > I am slightly worried that we only `join` this thread on `terminate`. > > Could we make

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

> On May 25, 2018, 5:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/grpc.cpp > > Lines 70 (patched) > > > > > > I am slightly worried that we only `join` this thread on `terminate`. > > Could we make

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

> On May 25, 2018, 3:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/grpc.cpp > > Lines 76 (patched) > > > > > > This seems almost like the libprocess equivalent of a throwing > > destructor. Could we

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203871 --- 3rdparty/libprocess/include/process/grpc.hpp Lines 27 (patched)

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203446 --- Patch looks great! Reviews applied: [67164, 67190, 67191, 67154,

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203394 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/ --- (Updated May 17, 2018, 10:23 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

> On May 17, 2018, 11:12 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Line 154 (original), 154 (patched) > > > > > > Do we want to actively disallow passing in lvalue `request`s

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203323 --- 3rdparty/libprocess/include/process/grpc.hpp Line 154

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203302 --- Patch looks great! Reviews applied: [67164, 67154, 67155, 67156,

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203297 --- PASS: Mesos patch 67157 was successfully built and tested.

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/#review203290 --- FAIL: Failed to apply the dependent review: 67155. Failed

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/ --- (Updated May 16, 2018, 8:49 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67157/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Zhitao