Re: Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

2018-05-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67210/ --- (Updated May 29, 2018, 10:13 a.m.) Review request for mesos, Chun-Hung Hsiao an

Re: Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

2018-05-29 Thread Benjamin Bannier
> On May 18, 2018, 8:53 p.m., Chun-Hung Hsiao wrote: > > Haven't take a good at these but they might be candidates to use the new > > macros: > > ``` > > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' > > 3rdparty/stout/ -r > > ... > > 3rdparty/stout//tests/ip_tests.cpp:

Re: Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

2018-05-18 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67210/#review203442 --- Fix it, then Ship it! Haven't take a good at these but they mig

Review Request 67210: Used `*_SOME` macro for checking `Try` values in stout.

2018-05-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67210/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos