Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review212368 --- Ship it! Ship It! - Gilbert Song On Nov. 8, 2018, 7:23

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review212028 --- Ship it! Ship It! - Gilbert Song On Nov. 8, 2018, 7:23

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211945 --- Ship it! Ship It! - Qian Zhang On Nov. 8, 2018, 11:23 p.m.,

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211773 --- src/CMakeLists.txt Lines 55 (patched)

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 25, 2018, 8:34 a.m., Qian Zhang wrote: > > cmake/CompilationConfigure.cmake > > Lines 449-452 (original), 449-452 (patched) > > > > > > Do we need to check the required headers/libs (like below) after

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211531 --- cmake/CompilationConfigure.cmake Lines 449-452 (original),

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 20, 2018, 9:39 a.m., Qian Zhang wrote: > > 3rdparty/CMakeLists.txt > > Lines 637 (patched) > > > > > > Do we need to check if we are using bundled libseccomp or pre-installed? > > > > This

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 20, 2018, 5:39 p.m., Qian Zhang wrote: > > configure.ac > > Lines 1607-1608 (patched) > > > > > > What is the difference between `use a preinstalled libseccomp` and > > `ignore all bundled libraries`?

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 20, 2018, 9:39 a.m., Qian Zhang wrote: > > cmake/CompilationConfigure.cmake > > Lines 569 (patched) > > > > > > Just curious why we need add this definition? It seems we do not do > > this for other

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211456 --- 3rdparty/CMakeLists.txt Lines 637 (patched)

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 12, 2018, 11:51 p.m., Gilbert Song wrote: > > configure.ac > > Lines 352 (patched) > > > > > > Do we have a plan to deprecate this configuraton flag in the future? > > E.g., always only compile the

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 12, 2018, 3:51 p.m., Gilbert Song wrote: > > configure.ac > > Lines 352 (patched) > > > > > > Do we have a plan to deprecate this configuraton flag in the future? > > E.g., always only compile the seccomp

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 12, 2018, 11:51 p.m., Gilbert Song wrote: > > configure.ac > > Lines 352 (patched) > > > > > > Do we have a plan to deprecate this configuraton flag in the future? > > E.g., always only compile the

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review211258 --- configure.ac Lines 352 (patched)

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/ --- (Updated Nov. 8, 2018, 3:23 p.m.) Review request for mesos, Andrew

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/ --- (Updated Oct. 22, 2018, 5:04 p.m.) Review request for mesos, Andrew

Re: Review Request 68016: Added libseccomp to the build.

> On July 31, 2018, 12:33 a.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 538-541 (patched) > > > > > > What targets need `ENABLE_SECCOMP_ISOLATOR` defined? Presumably this is > >

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/ --- (Updated Aug. 6, 2018, 1:38 p.m.) Review request for mesos, Andrew

Re: Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review206629 --- cmake/CompilationConfigure.cmake Lines 538-541 (patched)

Review Request 68016: Added libseccomp to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/ --- Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.