----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68016/#review206629 -----------------------------------------------------------
cmake/CompilationConfigure.cmake Lines 538-541 (patched) <https://reviews.apache.org/r/68016/#comment289680> What targets need `ENABLE_SECCOMP_ISOLATOR` defined? Presumably this is new code, so we don't have to leave this as a to-do. (And I'm guessing just `libmesos PRIVATE`?) - Andrew Schwartzmeyer On July 23, 2018, 9:17 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68016/ > ----------------------------------------------------------- > > (Updated July 23, 2018, 9:17 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, James > Peach, and Qian Zhang. > > > Bugs: MESOS-9032 > https://issues.apache.org/jira/browse/MESOS-9032 > > > Repository: mesos > > > Description > ------- > > This library is needed to implement Seccomp syscall filtering in the > Mesos containerizer. This patch introduces `seccomp-isolator` build > flag, which is used to include or exclude sources related to Seccomp > from the build. Since Seccomp is a Linux-specific feature, the flag > is disabled by default. Enabling `seccomp-isolator` means either: > > 1. Compiling and linking against the bundled version of libseccomp from > sources (default). > > 2. Linking against the libseccomp installed in the OS, > if `--with-libseccomp` build flag is provided. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > 3rdparty/Makefile.am 6123b8a0164d50f0bd771d2e5f485379811e7fcb > 3rdparty/cmake/Versions.cmake 0a897d808cd9e05ac0d1a4e1ca61b8f3538f0c4a > 3rdparty/versions.am 57792800c4b4b67dd55a316ce00480db6c253d34 > cmake/CompilationConfigure.cmake f80c265d117c70acda95da6b943cdd3e4e477daa > configure.ac e86c496140ee9732ad3204ef22ae8ce60cd5c079 > src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 > src/Makefile.am ecb95ef152fd37e5e83c4f6415489f4cf3959578 > > > Diff: https://reviews.apache.org/r/68016/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
