Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206799 --- src/Makefile.am Lines 1021 (patched)

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 1:23 p.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206797 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2018,

Re: Review Request 68141: Moved Framework implementation into separate file.

> On Aug. 2, 2018, 10:33 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp > > Lines 2981-2983 (original) > > > > > > I think these qualify to stay in ".hpp". Letting functions stay in header files can of

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 12:17 p.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206794 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206788 --- src/master/master.hpp Lines 2981-2983 (original)

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 10:26 a.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 10:18 a.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206748 --- PASS: Mesos patch 68141 was successfully built and tested.

Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2633