Re: Review Request 68224: Augmented `Statistics` to work with any collection.

> On Aug. 22, 2018, 2:30 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/statistics.hpp > > Line 108 (original), 148 (patched) > > > > > > Whoops? Can you remove this stray from the diff? Nope,

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review207724 --- Fix it, then Ship it! Looks good!

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/ --- (Updated Aug. 14, 2018, 12:48 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review207045 --- Overall looks good, just a couple of minor comments below:

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review207037 --- Fix it, then Ship it!

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

> On Aug. 6, 2018, 10:59 a.m., Benno Evers wrote: > > 3rdparty/libprocess/include/process/statistics.hpp > > Lines 60 (patched) > > > > > > Aren't you missing a `::value` after `std::is_same<>`, assuming you're > >

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/ --- (Updated Aug. 9, 2018, 2:20 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

> On Aug. 7, 2018, 11:46 p.m., Benjamin Mahler wrote: > > Can we just have a single function instead of keeping the specialized > > TimeSeries overload? At some point we're going to have to do the copy > > elimination here so we'll probably take random access iterators and index > > directly

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review206961 --- Can we just have a single function instead of keeping the

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review206875 --- 3rdparty/libprocess/include/process/statistics.hpp Lines 60

Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Repository: mesos