Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206928 --- PASS: Mesos patch 68239 was successfully built and tested. All

Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206920 --- Fix it, then Ship it!

Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/ --- (Updated Aug. 6, 2018, 11:42 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Jie Yu
> On Aug. 6, 2018, 10:35 p.m., Chun-Hung Hsiao wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1799 (patched) > > > > > > What's the reason of doing a pre-test cleanup first? To prevent > >

Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Chun-Hung Hsiao
> On Aug. 6, 2018, 10:35 p.m., Chun-Hung Hsiao wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 1957-1958 (original), 1990-1996 (patched) > > > > > > This test waits for all `TASK_RUNNING` before

Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206907 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 1799

Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/ --- (Updated Aug. 6, 2018, 8:31 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/#review206895 --- src/tests/containerizer/cni_isolator_tests.cpp Lines 2002

Review Request 68239: Updated port mapper CNI test.

2018-08-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68239/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos