Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-25 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review209003 --- Ship it! Ship It! - Meng Zhu On Sept. 24, 2018, 5:22 p.m.,

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-24 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208981 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/ --- (Updated Sept. 25, 2018, 12:22 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-21 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208911 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/ --- (Updated Sept. 21, 2018, 11:24 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-21 Thread Benjamin Mahler
> On Sept. 19, 2018, 5:54 p.m., Meng Zhu wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 316 (patched) > > > > > > Can't we just use the client map? > > > >

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208779 --- src/master/allocator/sorter/drf/sorter.cpp Line 311 (original),

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208768 --- src/master/allocator/sorter/drf/sorter.hpp Lines 249 (patched)

Re: Review Request 68732: Cached weights in the sorters nodes.

2018-09-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208727 --- FAIL: Failed to apply the current review. Failed command:

Review Request 68732: Cached weights in the sorters nodes.

2018-09-18 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos