Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review213274 --- Ship it! Ship It! - Gilbert Song On Feb. 27, 2019, 6:46

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Feb. 27, 2019, 10:46 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-26 Thread Qian Zhang
> On Feb. 25, 2019, 10:15 p.m., Benjamin Bannier wrote: > > How is this patch related to https://reviews.apache.org/r/69542/? Some > > issues were raised over there and a discussion started. We should strongly > > avoid loosing such context as it makes it harder to understand patches > >

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Feb. 26, 2019, 10:54 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review213181 --- Ship it! Ship It! - Gilbert Song On Jan. 28, 2019, 11:34

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review213165 --- How is this patch related to https://reviews.apache.org/r/69542/?

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-25 Thread Qian Zhang
> On Feb. 25, 2019, 11:33 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 2684 (patched) > > > > > > IIRC, this is because we want to do GID deallocate based on the PARENT >

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-02-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review213129 --- src/slave/containerizer/mesos/containerizer.cpp Lines 2684

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-01-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Jan. 29, 2019, 3:34 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-01-06 Thread Qian Zhang
> On Dec. 6, 2018, 9:14 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1631 (patched) > > > > > > Probably, we should add `CHECK(!launchInfo.has_supplementary_groups()) >

Re: Review Request 69345: Made non-root containers can access PARENT type SANDBOX_PATH volume.

2019-01-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Jan. 7, 2019, 8:30 a.m.) Review request for mesos, Andrei Budnik,