Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review213103 --- Bad review! Reviews applied: [69559] Error: 2019-02-22 23:53:14

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211397 --- Ship it! Ship It! - Till Toenshoff On Dec. 17, 2018, 3:55

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211359 --- PASS: Mesos patch 69559 was successfully built and tested.

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- (Updated Dec. 17, 2018, 4:55 p.m.) Review request for mesos, Andrew

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

> On Dec. 17, 2018, 1:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Line 77 (original), 72 (patched) > > > > > > Does this display as JSON? It doesn't as we go back to the old codebase. > On

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

> On Dec. 17, 2018, 12:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 277 (patched) > > > > > > Python's way of `contains` for a dictionary is commonly something like > > this; > > > >

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211355 --- support/verify-reviews.py Lines 36 (patched)

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211340 --- Ship it! Ship It! - Vinod Kone On Dec. 13, 2018, 3:59 p.m.,

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211332 --- PASS: Mesos patch 69559 was successfully built and tested.

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

> On Dec. 13, 2018, 9:58 p.m., Vinod Kone wrote: > > git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > Failed command: git reset --hard > > b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > > > Error: b'fatal: Cannot do hard reset with paths.\n' > > > > > > This looks bad?

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211306 --- git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n'

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211294 --- PASS: Mesos patch 69559 was successfully built and tested.

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- (Updated Dec. 13, 2018, 3:08 p.m.) Review request for mesos, Andrew

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211263 --- LGTM. Have you tested this script by running locally?

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211243 --- PASS: Mesos patch 69559 was successfully built and tested.

Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/ --- Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, and Vinod