Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review212038 --- Ship it! Ship It! - Joseph Wu On Jan. 15, 2019, 3:13 p.m.,

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 15, 2019, 11:13 p.m.) Review request for mesos, Benjamin

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

> On Jan. 15, 2019, 8:29 p.m., Benjamin Bannier wrote: > > 3rdparty/grpc-1.10.0.patch > > Lines 33 (patched) > > > > > > Not related to this patch, but I wonder how this was needed given that > > we didn't patch

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review212032 --- Fix it, then Ship it! LGTM. 3rdparty/grpc-1.10.0.patch Lines

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211968 --- PASS: Mesos patch 69708 was successfully built and tested.

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 14, 2019, 9:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 14, 2019, 8:21 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211960 --- 3rdparty/grpc-1.10.0.patch Lines 22-29 (patched)

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211924 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 12, 2019, 12:27 a.m.) Review request for mesos, Benjamin

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211922 --- This looks good to me, but I am not a cmake expert. It would be

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211900 --- PASS: Mesos patch 69708 was successfully built and tested.

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 11, 2019, 6:08 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211855 --- PASS: Mesos patch 69708 was successfully built and tested.

Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-9519