Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-18 Thread Qian Zhang
> On Feb. 13, 2019, 9:28 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 300 (patched) > > > > > > Given that `state::checkpoint` is **atomic**, we can not

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-15 Thread Andrei Budnik
> On Feb. 13, 2019, 1:28 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 300 (patched) > > > > > > Given that `state::checkpoint` is **atomic**, we can not

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-15 Thread Qian Zhang
> On Feb. 13, 2019, 9:28 p.m., Andrei Budnik wrote: > > Thanks for the patch! > > I think we should implement a test for this. Otherwise, it would be very > > dangerous to _refactor_ this part of code in the future. > > If you have no chance to implement a test for this now, please feel free to

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-15 Thread Qian Zhang
> On Feb. 13, 2019, 9:28 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 300 (patched) > > > > > > Given that `state::checkpoint` is **atomic**, we can not

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212803 --- Patch looks great! Reviews applied: [69972] Passed command:

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-13 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212795 --- Thanks for the patch! I think we should implement a test for

Re: Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/#review212791 --- PASS: Mesos patch 69972 was successfully built and tested.

Review Request 69972: Skipped the container which has no checkpointed volumes during recovery.

2019-02-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69972/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9507