Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/ --- (Updated July 31, 2019, 11:31 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

> On July 31, 2019, 7:23 a.m., Chun-Hung Hsiao wrote: > > src/tests/mesos.hpp > > Lines 3038 (patched) > > > > > > It seems that I'm wrong about `Self`, which seems to become a type > > template in a class

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/#review216979 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 3038

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/ --- (Updated July 27, 2019, 9:04 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

> On July 18, 2019, 9:48 p.m., Chun-Hung Hsiao wrote: > > src/tests/mesos.hpp > > Lines 3361-3372 (patched) > > > > > > No need to introduce this type alias in this class template since the > > class template

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/#review216741 --- src/tests/master_tests.cpp Line 9017 (original), 9017 (patched)

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

> On June 6, 2019, 12:53 a.m., Chun-Hung Hsiao wrote: > > src/tests/master_tests.cpp > > Line 9017 (original), 9017 (patched) > > > > > > Not yours, but it seems to me that the dequeueing of the > >

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/#review215705 --- s/completelt/completely/ in the description.

Re: Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/#review215532 --- Patch looks great! Reviews applied: [70728] Passed command:

Review Request 70728: Backed `MockResourceProvider` by a process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70728/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos