Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Meng Zhu
> On Aug. 19, 2019, 4:12 p.m., Benjamin Mahler wrote: > > Thanks! > > > > We could probably unit test the `empty()` function (for each case), then > > for role tracking, we could use one case (e.g. weights) to test more cases. > > Specifically, right now we are only testing the case wehre

Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/#review217306 --- Fix it, then Ship it! Thanks! We could probably unit test the

Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/ --- (Updated Aug. 19, 2019, 3:34 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/#review217299 --- src/tests/sorter_tests.cpp Lines 2188 (patched)

Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository: