Re: Review Request 71833: Created unix domain socket on agent startup.

2020-01-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/#review219213 --- Fix it, then Ship it! src/common/domain_sockets.hpp Lines 31 (

Re: Review Request 71833: Created unix domain socket on agent startup.

2020-01-09 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/ --- (Updated Jan. 10, 2020, 1:46 a.m.) Review request for mesos and Benjamin Bannie

Re: Review Request 71833: Created unix domain socket on agent startup.

2019-12-09 Thread Benno Evers
> On Dec. 5, 2019, 3:12 p.m., Benjamin Bannier wrote: > > src/tests/cluster.cpp > > Lines 630 (patched) > > > > > > There is another, currently unhandled branch where > > `domain_socket_location` exists, but is not

Re: Review Request 71833: Created unix domain socket on agent startup.

2019-12-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/#review218939 --- src/slave/main.cpp Lines 614 (patched)

Re: Review Request 71833: Created unix domain socket on agent startup.

2019-12-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71833/ --- (Updated Dec. 3, 2019, 6:30 p.m.) Review request for mesos and Benjamin Bannier