Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221613 --- Ship it! Ship It! - Greg Mann On Aug. 11, 2020, 8:32 a.m., Q

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/ --- (Updated Aug. 11, 2020, 4:32 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

> On Aug. 6, 2020, 1:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 115-117 (patched) > > > > > > This seems pretty simple, could we do it now? > > Qian Zhang

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/ --- (Updated Aug. 10, 2020, 10:37 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/ --- (Updated Aug. 7, 2020, 11:20 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

> On Aug. 6, 2020, 9:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 115-117 (patched) > > > > > > This seems pretty simple, could we do it now? > > Qian Zhang

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

> On Aug. 6, 2020, 9:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > > Lines 85 (patched) > > > > > > Does the value of this map really need to be an `Owned`, rather tha

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

> On Aug. 6, 2020, 1:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > > Lines 85 (patched) > > > > > > Does the value of this map really need to be an `Owned`, rather tha

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/ --- (Updated Aug. 6, 2020, 5:23 p.m.) Review request for mesos, Andrei Budnik and G

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

> On Aug. 6, 2020, 9:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > > Lines 85 (patched) > > > > > > Does the value of this map really need to be an `Owned`, rather tha

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221469 --- src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp L

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221476 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72681, 72715, 7

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221464 --- Patch looks great! Reviews applied: [72660, 72661, 72672, 72681,

Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10153 ht