Re: Review Request 33918: Added resources estimator abstraction for oversubscription.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82760 --- LGTM except for the naming. I would call it ResourceEstimator instead of Resource*s*Estimator. The former is just easier to pronounce. Also, this is to be consistent with things like ResourceMonitor and StatusUpdateManager which also deal with multiples of resources and status updates. - Vinod Kone On May 6, 2015, 10:35 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/ --- (Updated May 6, 2015, 10:35 p.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-2649 https://issues.apache.org/jira/browse/MESOS-2649 Repository: mesos Description --- Added resources estimator abstraction for oversubscription. This patch defines the interface of the resources estimator and creates a default stub implementation. Diffs - include/mesos/slave/resources_estimator.hpp PRE-CREATION src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b src/slave/resources_estimator.hpp PRE-CREATION src/slave/resources_estimator.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33918/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 33919: Integrated resources estimator with the slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review82773 --- Patch looks great! Reviews applied: [33918, 33919] All tests passed. - Mesos ReviewBot On May 6, 2015, 10:35 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/ --- (Updated May 6, 2015, 10:35 p.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone. Bugs: MESOS-2653 https://issues.apache.org/jira/browse/MESOS-2653 Repository: mesos Description --- Integrated resources estimator with the slave. This patch hooks the resources estimator with the slave. Slave will simply forward the estimation from the resources estimator to the master. Diffs - src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b src/messages/messages.proto 98d859f3db6013a2e155d838f590a0cde6dc5ed5 src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 src/slave/slave.hpp 654a8698be88e0d0f588190775dc3eee6b36f92e src/slave/slave.cpp c78ee3c9e7fc38ad364e83f4abe267e86bfbbc13 src/tests/oversubscription_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33919/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82727 --- src/master/http.cpp https://reviews.apache.org/r/33871/#comment133528 I think the usage is to leave spaces on the line before breaking. I noticed it was like this on the `DESCRIPTION` part and on other `HELP` strings like `TASKS_HELP` eg: ```C++ TLDR( Shuts down a running framework by shutting down all tasks/executors and removing the framework.), ``` - Isabel Jimenez On May 6, 2015, 5:14 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/ --- (Updated May 6, 2015, 5:14 p.m.) Review request for mesos, Isabel Jimenez and Marco Massenzio. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- This is for consistency with the new TEARDOWN call in the scheduler api. Diffs - src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3 Diff: https://reviews.apache.org/r/33871/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.
On May 6, 2015, 8:41 p.m., Isabel Jimenez wrote: Besides this, LGTM! - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82727 --- On May 6, 2015, 5:14 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/ --- (Updated May 6, 2015, 5:14 p.m.) Review request for mesos, Isabel Jimenez and Marco Massenzio. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- This is for consistency with the new TEARDOWN call in the scheduler api. Diffs - src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3 Diff: https://reviews.apache.org/r/33871/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/#review82725 --- Ship it! LGTM! - Isabel Jimenez On May 6, 2015, 5:15 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/ --- (Updated May 6, 2015, 5:15 p.m.) Review request for mesos, Isabel Jimenez and Marco Massenzio. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- Just a rename of the test file and tests. No functional change. Diffs - src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b src/tests/shutdown_tests.cpp b3e999ee2809bab1e083851ca3fbe21776fd0321 Diff: https://reviews.apache.org/r/33872/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/ --- (Updated May 6, 2015, 9:32 p.m.) Review request for mesos, Isabel Jimenez and Marco Massenzio. Changes --- isabel's comments. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- This is for consistency with the new TEARDOWN call in the scheduler api. Diffs (updated) - src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3 Diff: https://reviews.apache.org/r/33871/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82730 --- src/master/http.cpp https://reviews.apache.org/r/33871/#comment133530 same as above - Isabel Jimenez On May 6, 2015, 5:14 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/ --- (Updated May 6, 2015, 5:14 p.m.) Review request for mesos, Isabel Jimenez and Marco Massenzio. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- This is for consistency with the new TEARDOWN call in the scheduler api. Diffs - src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3 Diff: https://reviews.apache.org/r/33871/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 33875: Removed unused collect cycle in resource monitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33875/#review82709 --- Ship it! lgtm modulo jie's comments. src/slave/monitor.hpp https://reviews.apache.org/r/33875/#comment133504 s/monitoring/executor/ - Vinod Kone On May 6, 2015, 4:01 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33875/ --- (Updated May 6, 2015, 4:01 p.m.) Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description --- See summary Diffs - src/slave/monitor.hpp 69c60a10187f8ea617c6be9738b28e8103e0ed27 src/slave/monitor.cpp 398af010564e999b46e38560ba1e652261a9420c src/tests/monitor_tests.cpp 899af4449140dd787cfe829c010f94b52e98937b Diff: https://reviews.apache.org/r/33875/diff/ Testing --- make check Thanks, Niklas Nielsen
Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/ --- Review request for mesos, Isabel Jimenez and Marco Massenzio. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- This is for consistency with the new TEARDOWN call in the scheduler api. Diffs - src/master/http.cpp fb448256d7ced1f47ea48ccfca2ae267bc26ef94 src/master/master.hpp 49ee050ca4d2b2c5f75ce864fcf6ae703dfdeadd src/master/master.cpp bee842557c8397428ca51e46faa182a391584be3 Diff: https://reviews.apache.org/r/33871/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/#review82707 --- Patch looks great! Reviews applied: [33871, 33872] All tests passed. - Mesos ReviewBot On May 6, 2015, 5:15 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/ --- (Updated May 6, 2015, 5:15 p.m.) Review request for mesos, Isabel Jimenez and Marco Massenzio. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- Just a rename of the test file and tests. No functional change. Diffs - src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b src/tests/shutdown_tests.cpp b3e999ee2809bab1e083851ca3fbe21776fd0321 Diff: https://reviews.apache.org/r/33872/diff/ Testing --- make check Thanks, Vinod Kone
