----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/#review82760 -----------------------------------------------------------
LGTM except for the naming. I would call it ResourceEstimator instead of Resource*s*Estimator. The former is just easier to pronounce. Also, this is to be consistent with things like ResourceMonitor and StatusUpdateManager which also deal with multiples of resources and status updates. - Vinod Kone On May 6, 2015, 10:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33918/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 10:35 p.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2649 > https://issues.apache.org/jira/browse/MESOS-2649 > > > Repository: mesos > > > Description > ------- > > Added resources estimator abstraction for oversubscription. > > This patch defines the interface of the resources estimator and creates a > default stub implementation. > > > Diffs > ----- > > include/mesos/slave/resources_estimator.hpp PRE-CREATION > src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b > src/slave/resources_estimator.hpp PRE-CREATION > src/slave/resources_estimator.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/33918/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
