Re: Review Request 35433: CHECK that checkpointed resources exist on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review87849 --- Patch looks great! Reviews applied: [35433] All tests passed. -

Re: Review Request 34375: Removed use of namespace aliases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/#review87851 --- Patch looks great! Reviews applied: [34375] All tests passed. -

Re: Review Request 35395: Improvements to the synchronized macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35395/ --- (Updated June 14, 2015, 2:20 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35395: Improvements to Synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35395/ --- (Updated June 13, 2015, 12:51 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35095: Update linux fs to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35095/#review87821 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:54

Re: Review Request 35094: Update libprocess gate to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35094/#review87820 --- Ship it! Same comment as https://reviews.apache.org/r/35093 here,

Re: Review Request 35097: Update mesos executor to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35097/#review87823 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 11:07

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/#review87830 --- Ship it! Ship It! - Benjamin Hindman On June 5, 2015, 7:42

Re: Review Request 35426: mesos: Use CHECK_SOME, CHECK_NONE, CHECK_ERROR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/#review87832 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 2:07

Re: Review Request 28763: Add configure flag to enable SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/#review87833 --- Ship it! Ship It! - Michael Park On June 13, 2015, 8:26 a.m.,

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87834 --- Ship it! Ship It! - Michael Park On June 13, 2015, 9:23 a.m.,

Re: Review Request 35426: mesos: Use CHECK_SOME, CHECK_NONE, CHECK_ERROR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/#review87835 --- Patch looks great! Reviews applied: [35422, 35423, 35425, 35426]

Re: Review Request 35096: Update mesos scheduler to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35096/#review87822 --- Ship it! Can also use synchronized with std::unique_lock here,

Re: Review Request 35098: Update module manager to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35098/#review87824 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:54

Re: Review Request 35099: Update cram_md5 to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35099/#review87826 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:55

Re: Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35253/ --- (Updated June 13, 2015, 2:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/#review87809 --- Patch looks great! Reviews applied: [35422, 35423] All tests

Re: Review Request 35089: Replace lock_guard with synchronized in fetcher_cache_test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35089/#review87813 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:53

Re: Review Request 35091: Update libprocess gmock to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35091/#review87815 --- Ship it! With MPark's refactor we can kill the 'UNREACHABLE()'!

Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/#review87816 --- 3rdparty/libprocess/include/process/future.hpp

Review Request 35426: mesos: Use CHECK_SOME, CHECK_NONE, CHECK_ERROR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35426/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 35100: Update hook manager to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35100/#review87828 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:55

Re: Review Request 35101: Update zookeeper tests to use synchronized.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35101/#review87829 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 10:55

Re: Review Request 35425: libprocess: Use CHECK_NONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35425/#review87831 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 2:06

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 7:13 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28763: Add configure flag to enable SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/ --- (Updated June 13, 2015, 8:26 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87783 --- Reviewed `libevent_ssl_socket.{hpp,cpp}`. I don't have much

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 8:27 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35253: Enable configure to detect libevent and openssl on Mac OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35253/#review87836 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 8:47 a.m.) Review request for mesos, Benjamin Hindman

Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35422/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/#review87808 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 12:24

Re: Review Request 35423: libprocess: Rebased for _CheckFatal changes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35423/ --- (Updated June 13, 2015, 12:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35422/ --- (Updated June 13, 2015, 12:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 35422: stout: Introduce CHECK_NONE and CHECK_ERROR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35422/#review87807 --- Ship it! Ship It! - Benjamin Hindman On June 13, 2015, 12:24

Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 9:23 a.m.) Review request for mesos, Benjamin Hindman

Review Request 35431: Enable Option to hold a noncopyable type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35431/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 35432: Enable move semantics for Future and Promise.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35432/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 35433: CHECK that checkpointed resources exist on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos

Re: Review Request 34375: Removed use of namespace aliases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34375/ --- (Updated June 13, 2015, 9:51 p.m.) Review request for mesos and Till

Re: Review Request 35431: Enable Option to hold a noncopyable type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35431/#review87847 --- Patch looks great! Reviews applied: [34276, 34517, 35431] All

Re: Review Request 35432: Enable move semantics for Future and Promise.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35432/#review87848 --- Patch looks great! Reviews applied: [35432] All tests passed. -