Re: Review Request 37168: MESOS-3063

2015-08-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review95227 --- src/examples/dynamic_reservation_framework.cpp (line 267)

Re: Review Request 37168: MESOS-3063

2015-08-12 Thread haosdent huang
> On Aug. 13, 2015, 2:56 a.m., haosdent huang wrote: > > Hi, @klaus1982 Thanks you for you nice example. I think you need add your Shepherd as reviewer in this patch. - haosdent --- This is an automatically generated e-mail. To reply,

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95230 --- Bad patch! Reviews applied: [37426, 37427] Failed command: ./suppo

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95231 --- Patch looks great! Reviews applied: [37423, 37424, 37417, 37416] A

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review95226 --- src/common/http.hpp (line 51)

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 13, 2015, 4:47 a.m.) Review request for mesos, Lily Chen and Timo

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-12 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95235 --- src/linux/perf.cpp (line 411)

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/#review95236 --- src/slave/containerizer/isolators/network/port_mapping.cpp (lines 8

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-12 Thread Timothy Chen
> On Aug. 12, 2015, 6:13 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 391 > > > > > > This will cause problem in the docker containerizer since we also try > > to mount in the socket when we launch execut

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 13, 2015, 5:39 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37328: Remove namespace ambiguity

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/ --- (Updated Aug. 13, 2015, 5:43 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review95240 --- Ship it! Looks good modulo minor fixes. I'll fix them and commit fo

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-12 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95238 --- src/slave/containerizer/provisioners/docker/token_manager.hpp (line

Re: Review Request 37328: Remove namespace ambiguity

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/#review95241 --- Patch looks great! Reviews applied: [37302, 37303, 37328] All test

<    1   2