---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/
---
(Updated Aug. 24, 2015, 4:02 p.m.)
Review request for mesos, Joerg Schad,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/#review96143
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/
---
Review request for mesos, Joerg Schad and Michael Park.
Bugs: MESOS-2924
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review96139
---
Given the rather complicated setup of this ( destroy - Destroyer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/#review96144
---
src/linux/cgroups.cpp (lines 1486 - 1487)
On Aug. 24, 2015, 3:05 p.m., Alexander Rojas wrote:
src/linux/cgroups.cpp, line 1750
https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1750
Not sure if `chain` needs to be an attribute. The only reason I see is
the discard call in `finalize()`. But if it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review96166
---
src/linux/perf.cpp (line 418)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 24, 2015, 5:16 p.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review96172
---
src/linux/perf.cpp (line 418)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37722/
---
(Updated Aug. 24, 2015, 11:26 a.m.)
Review request for mesos, Lily Chen, Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/
---
(Updated Aug. 24, 2015, 11:26 a.m.)
Review request for mesos, Benjamin
On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote:
src/linux/perf.cpp, line 418
https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418
This is not expected, right?
Paul Brett wrote:
It would be a rare event but not completly unexpected. After all, perf
can
On Aug. 21, 2015, 11:35 a.m., Alexander Rukletsov wrote:
include/mesos/mesos.proto, lines 917-920
https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917
I think the name `Unavailability` is too specific to maintenance, how
about something more generic, like
On June 15, 2015, 12:07 p.m., Niklas Nielsen wrote:
Hey Robert; BenH helped out and wrote a PoC patch here
https://reviews.apache.org/r/35405
In short; it is not safe to delete the detector at this point. The patch
above does it in join() and has a good descriptive block of comment
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/#review96168
---
src/tests/containerizer/perf_tests.cpp (line 52)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37722/
---
Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/#review96170
---
Ship it!
LGTM, sorry for the long turn around time on this review
On Aug. 24, 2015, 5:53 p.m., Cong Wang wrote:
src/linux/perf.cpp, line 418
https://reviews.apache.org/r/37416/diff/5/?file=1045148#file1045148line418
This is not expected, right?
It would be a rare event but not completly unexpected. After all, perf can be
upgraded while mesos is
On June 9, 2015, 6:25 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35405/#review96176
---
Robert; did you still run into problems with the current patch? If
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/
---
(Updated Aug. 24, 2015, 11:33 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362/
---
(Updated Aug. 24, 2015, 12:08 p.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 24, 2015, 11:48 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37364/
---
(Updated Aug. 24, 2015, 12:09 p.m.)
Review request for mesos, Benjamin
On Aug. 19, 2015, 6:11 a.m., Timothy Chen wrote:
src/slave/containerizer/provisioners/docker/store.cpp, line 1
https://reviews.apache.org/r/37197/diff/6/?file=1041380#file1041380line1
Btw this is actually renamed to be local store later right?
How about just remove the
On Aug. 12, 2015, 10:31 a.m., Joseph Wu wrote:
src/master/maintenance.cpp, lines 126-130
https://reviews.apache.org/r/37325/diff/2/?file=1037747#file1037747line126
Note: Considering the machine field in the master's local state
(https://reviews.apache.org/r/37170/diff/2#0.8), it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37358/
---
(Updated Aug. 24, 2015, 11:54 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96138
---
Ship it!
Ship It!
- Guangya Liu
On 八月 12, 2015, 1:15 a.m., Jose
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/
---
(Updated Aug. 24, 2015, 9:31 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37726/
---
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---
(Updated Aug. 24, 2015, 2:14 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37314/
---
(Updated Aug. 24, 2015, 11:43 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
---
Ship it!
Ship It!
- Jose Guilherme Vanz
On Aug. 12, 2015, 1:15
On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote:
Ship It!
Jose Guilherme Vanz wrote:
Ops... sorry.
My Ship it is not valid. I'm the author... sorry
- Jose Guilherme
---
This is an automatically generated e-mail. To
On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote:
Ship It!
Ops... sorry.
- Jose Guilherme
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37729/
---
Review request for mesos, Jie Yu, Joris Van Remoortere, and Kapil Arya.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37729/#review96215
---
Ship it!
Ship It!
- Jie Yu
On Aug. 24, 2015, 9:09 p.m., Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/
---
(Updated Aug. 24, 2015, 9:30 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33752/
---
(Updated Aug. 24, 2015, 9:54 p.m.)
Review request for mesos, Cody Maloney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37729/#review96214
---
Ship it!
Ship It!
- Kapil Arya
On Aug. 24, 2015, 5:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36127/#review96218
---
Patch looks great!
Reviews applied: [36127]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37541/
---
(Updated Aug. 24, 2015, 9:32 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96244
---
Ship it!
Ship It!
include/mesos/mesos.proto (line 98)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37722/#review96252
---
The slave provisioners path LGTM!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review96251
---
Bad patch!
Reviews applied: [37585]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37479/
---
(Updated Aug. 25, 2015, 1:28 a.m.)
Review request for mesos, Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37501/#review96232
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 15, 2015, 4:35 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review96233
---
Patch looks great!
Reviews applied: [37426, 37427]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37738/
---
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96240
---
This review is a bit hard to follow because it's doing multiple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
---
(Updated Aug. 25, 2015, 1:31 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---
(Updated Aug. 24, 2015, 5:14 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review96263
---
Patch looks great!
Reviews applied: [36410, 36411, 36412, 36413,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/
---
(Updated Aug. 25, 2015, 1:32 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---
(Updated Aug. 25, 2015, 1:33 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96269
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 12:14 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37735/
---
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37722/#review96246
---
Patch looks great!
Reviews applied: [37722]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37726/#review96254
---
src/tests/containerizer/filesystem_isolator_tests.cpp (line 485)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/#review96265
---
include/mesos/scheduler/scheduler.proto (line 70)
On Aug. 18, 2015, 9:33 p.m., Joseph Wu wrote:
src/master/master.hpp, line 478
https://reviews.apache.org/r/37175/diff/3/?file=1043316#file1043316line478
Why is this return type `Nothing`, instead of `void`?
It was `Nothing` as I was calling this function from the tests before. It
On Aug. 25, 2015, 12:33 a.m., Timothy Chen wrote:
src/tests/containerizer/filesystem_isolator_tests.cpp, line 485
https://reviews.apache.org/r/37726/diff/1/?file=1048647#file1048647line485
How about trying multiple rootfs in the same container?
Yeah, that needs a few refactor on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/
---
(Updated Aug. 24, 2015, 5:59 p.m.)
Review request for mesos, Benjamin Hindman,
On Aug. 12, 2015, 9:16 p.m., Joseph Wu wrote:
Why are the InverseOffers (and Offers) hashed as pointers?
Can you point to an example. I don't understand your question.
- Joris
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37621/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37280/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
---
(Updated Aug. 25, 2015, 2:14 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
On Aug. 19, 2015, 6:21 a.m., Timothy Chen wrote:
src/slave/containerizer/provisioners/docker.hpp, line 81
https://reviews.apache.org/r/37198/diff/6/?file=1041387#file1041387line81
Did we introduce DockerImageName later?
A pair of strings is pretty confusing, how about pulling
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37541/
---
(Updated Aug. 25, 2015, 12:17 a.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/
---
(Updated Aug. 25, 2015, 12:16 a.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96259
---
include/mesos/mesos.proto (line 125)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37496/
---
(Updated Aug. 25, 2015, 1:34 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/
---
(Updated Aug. 25, 2015, 1:35 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37495/
---
(Updated Aug. 25, 2015, 1:34 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review96266
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 24, 2015, 9:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37234/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
---
(Updated Aug. 25, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
---
(Updated Aug. 25, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
---
(Updated Aug. 25, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/
---
(Updated Aug. 25, 2015, 2:12 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37734/
---
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96272
---
src/messages/messages.proto (line 350)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37738/#review96277
---
Patch looks great!
Reviews applied: [37726, 37734, 37735, 37738]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37497/#review96280
---
Bad patch!
Reviews applied: [37196, 37197, 37198, 37200]
Failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/#review96281
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 2:13 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review96294
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 2:44 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/
---
(Updated Aug. 25, 2015, 2:44 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96285
---
Patch looks great!
Reviews applied: [37655]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37621/#review96296
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 2:13 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review96284
---
include/mesos/v1/mesos.proto (line 907)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review96291
---
Patch looks great!
Reviews applied: [36321, 36571, 37314, 37325,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
---
include/mesos/master/quota.proto (line 19)
98 matches
Mail list logo