Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38333/ --- Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang

Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38333/#review98764 --- Patch looks great! Reviews applied: [38333] All tests passed. -

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

> On Sept. 11, 2015, 6:56 a.m., Marco Massenzio wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 600-601 > > > > > > the `+` should be at the end of the line (before the

Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- Review request for mesos and Michael Park. Bugs: MESOS-3405

Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38334/ --- Review request for mesos. Bugs: MESOS-3408

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review98771 --- Bad patch! Reviews applied: [38335] Failed command:

Re: Review Request 37502: Add CMAKE_CXX_FLAGS to GMOCK_CONFIG_CMD in CMake.

> On Sept. 11, 2015, 7:22 p.m., Alex Clemmer wrote: > > I think that `-DGTEST_USE_OWN_TR1_TUPLE` is actually unnecessary now that > > you've upgraded to GMock 1.7 (in commie > > a8970ce78f1abbee3dd4de282d54ced38d0e5fa1). Let me just double-check my > > understanding here just to make sure

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Sept. 13, 2015, 8:34 p.m.) Review request for mesos, Benjamin

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/ --- (Updated Sept. 13, 2015, 8:34 p.m.) Review request for mesos, Benjamin

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/ --- (Updated Sept. 13, 2015, 8:34 p.m.) Review request for mesos, Benjamin

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/ --- (Updated Sept. 13, 2015, 8:34 p.m.) Review request for mesos, Benjamin

Review Request 38338: Enhanced option for Docker cli volume plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3392

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review98779 --- Patch looks great! Reviews applied: [38338] All tests passed. -

Review Request 38337: Extract gz file in fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38337/ --- Review request for mesos and Michael Park. Bugs: MESOS-3407

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

> On Sept. 10, 2015, 3 a.m., Benjamin Hindman wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 173-177 > > > > > > A suggestion to keep 'allocation' const& and avoid the double lookup: > > > >

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

> On Aug. 31, 2015, 1:56 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 1118 > > > > > > s/send inverse offer/deallocate resources/ This is tricky. We decided to use the word

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Sept. 13, 2015, 8:32 p.m.) Review request for mesos, Benjamin

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/ --- (Updated Sept. 13, 2015, 8:32 p.m.) Review request for mesos, Benjamin

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/ --- (Updated Sept. 13, 2015, 8:32 p.m.) Review request for mesos, Benjamin

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37176/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

> On Aug. 28, 2015, 8:49 p.m., Benjamin Hindman wrote: > > src/tests/master_maintenance_tests.cpp, line 97 > > > > > > Can we do this ASAP? Either now or already as an independent review on > > this chain so that we

Re: Review Request 38337: Extract gz file in fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38337/#review98775 --- Patch looks great! Reviews applied: [38337] All tests passed. -

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 6, 2015, 8:14 a.m., Klaus Ma wrote: > > src/master/http.cpp, line 1570 > > > > > > Should be LostSlaveMessage? We end up sending both. I've modified the comment to make this more clear. Thanks! -

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

> On Sept. 2, 2015, 10:04 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 138-141 > > > > > > Consider Doxygen-ification. I don't want to start another debate around "mixed vs not mixed doxygen

Re: Review Request 37821: Join threads in libprocess when shutting down.

> On Sept. 10, 2015, 8:20 a.m., Michael Park wrote: > > I've made a few nit comments below but I have some higher-level questions. > > > > (1) In this patch, when the destructor of `ProcessManager` is invoked we > > immediately start to ignore messages. It's not obvious to me that this is >

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/ --- (Updated Sept. 13, 2015, 11:01 p.m.) Review request for mesos, Benjamin

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review98792 --- src/master/http.cpp (line 1606)

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38251/ --- (Updated 九月 14, 2015, 2:19 a.m.) Review request for mesos, Joris Van

Re: Review Request 37821: Join threads in libprocess when shutting down.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review98789 --- Patch looks great! Reviews applied: [37821] All tests passed. -

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review98790 --- src/master/master.cpp (lines 4131 - 4134)

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review98801 --- Ship it! Ship It! - Benjamin Hindman On Sept. 13, 2015, 8:33

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review98806 --- src/master/http.cpp (lines 1622 - 1624)

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/#review98808 --- Ship it! include/mesos/type_utils.hpp (line 326)

Review Request 38343: mesos: Fixed punctuation in log message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38343/ --- Review request for mesos, Joris Van Remoortere and Niklas Nielsen. Repository:

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Sept. 14, 2015, 5:15 a.m.) Review request for mesos and Michael Park.

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37176/#review98800 --- Ship it! Ship It! - Benjamin Hindman On Sept. 13, 2015, 8:33

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review98798 --- Ship it! Ship It! - Benjamin Hindman On Sept. 13, 2015, 8:33

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review98802 --- Ship it! Still a Ship It, just a minor nit.

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review98803 --- Ship it! src/master/master.cpp (line 3283)

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review98797 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 296)

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote: > > src/master/http.cpp, lines 1622-1624 > > > > > > Why don't we want to send lost slave messages? Sorry, I meant: why don't we want to let lost slave

Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/ --- Review request for mesos and Michael Park. Bugs: MESOS-3405