Re: Review Request 38844: Added unit tests for Call validation in Agent

> On Sept. 29, 2015, 8:11 p.m., Anand Mazumdar wrote: > > Can you also update the new tests to use the updated way to test recovery > > of Agent as done by the other tests ? ( Otherwise, these would be flaky ) Done :) Thanks - Isabel

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review101003 --- src/slave/validation.cpp (line 57)

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

> On Sept. 29, 2015, 12:47 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/socket.cpp, lines 42-44 > > > > > > Just as an aside, it's unfortunate the caller has to do this, we should > > consider doing the same

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/ --- (Updated Sept. 29, 2015, 8:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

> On Sept. 29, 2015, 8:01 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/socket.cpp, line 42 > > > > > > newline :) you meant adding one above it right? - Chi

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38858/ --- (Updated Sept. 29, 2015, 7:48 p.m.) Review request for mesos, Timothy Chen and

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100999 --- Ship it! Thanks Chi, just some minor cleanups to style. Once

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). > > Isabel Jimenez wrote: > We

Re: Review Request 38837: CMake: Disable agent build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38837/ --- (Updated Sept. 29, 2015, 8:21 p.m.) Review request for mesos, Artem

Re: Review Request 38827: CMake: Expanded support for compiling much of the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38827/ --- (Updated Sept. 29, 2015, 8:21 p.m.) Review request for mesos, Artem

Re: Review Request 38468: docs: Added discussion of finding a shepherd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38468/#review101004 --- Patch looks great! Reviews applied: [38468] All tests passed. -

<    1   2