----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100999 -----------------------------------------------------------
Ship it! Thanks Chi, just some minor cleanups to style. Once updated, I'll get this committed. 3rdparty/libprocess/src/socket.cpp (lines 39 - 40) <https://reviews.apache.org/r/38809/#comment158301> In general we try to wrap comments so as to avoid jaggedness, e.g. ``` // If the caller passed in a file descriptor, we do not own its life // cycle and must not close it. ``` ``` // If the caller passed in a file descriptor, we do // not own its life cycle and must not close it. ``` The latter is easier on the eyes :) 3rdparty/libprocess/src/socket.cpp (line 42) <https://reviews.apache.org/r/38809/#comment158302> newline :) - Ben Mahler On Sept. 29, 2015, 6:11 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38809/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 6:11 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3519 > https://issues.apache.org/jira/browse/MESOS-3519 > > > Repository: mesos > > > Description > ------- > > socket: refactor to use Option and fix file descriptor leaks. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp 817cb37 > 3rdparty/libprocess/src/socket.cpp 5879423 > > Diff: https://reviews.apache.org/r/38809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
