Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40242/ --- (Updated Nov. 20, 2015, 10:32 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40245: Fixed typos in comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40245/ --- (Updated Nov. 20, 2015, 10:31 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/ --- (Updated Nov. 20, 2015, 10:32 p.m.) Review request for mesos, Greg Mann and Mic

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote: > > src/master/http.cpp, line 612 > > > > > > The `volumes.flatten()` here looks incorrect to me. For `/reserve`, we > > call `flatten` since the `required` resourc

Re: Review Request 40305: Added URI fetcher interface.

> On Nov. 18, 2015, 7:39 p.m., Vinod Kone wrote: > > include/mesos/uri/fetcher.hpp, line 49 > > > > > > Plugin might be confusing with Module. > > > > Not sure what's a better alternative name is, Downloader?

Re: Review Request 40403: Added streaming and construction methods for URI.

> On Nov. 18, 2015, 7:54 p.m., Vinod Kone wrote: > > src/uri/schemes/http.hpp, line 38 > > > > > > consider merging `uri/schemes/*` and `src/uri/utils.cpp` into a single > > `src/uri.cpp` file. I thought about that

Re: Review Request 40378: Added link to upgrade guide to documentation page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40378/#review107435 --- Looks good, but we should find a better place to put that link. d

Re: Review Request 40378: Added link to upgrade guide to documentation page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40378/ --- (Updated Nov. 20, 2015, 10:54 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 53-75 > > > > > > What's the motivation of storing this? Should the caller already have > > those informati

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 328 > > > > > > I don't like the name 'execute'. When you create the Subprocess > > instance, the subprocss

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 328 > > > > > > I don't like the name 'execute'. When you create the Subprocess > > instance, the subprocss

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 53-75 > > > > > > What's the motivation of storing this? Should the caller already have > > those informati

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Nov. 20, 2015, 11:25 p.m.) Review request for mesos, Jie Yu, Paul Bret

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 119-130 > > > > > > Why not just use a single `int status` field here. The users can use > > WEXITSTATUS .

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 336-343 > > > > > > Why introduce this method? I think the caller should be responsible for > > killing th

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/ --- (Updated Nov. 20, 2015, 11:36 p.m.) Review request for mesos, Ian Downes and Ji

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review107443 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107444 --- src/cli/execute.cpp (line 237)

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107445 --- Ship it! Ship It! - Timothy Chen On Nov. 20, 2015, 7:45 a.m., J

Re: Review Request 40371: Changed mesos-execute to add containerizer option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review107446 --- Thanks Jojy, I'll fix these myself and merge. - Timothy Chen On

Re: Review Request 40560: Removed redundant fields from Update message in Executor API Protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40560/#review107448 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m., An

Re: Review Request 40561: Added an overload for createStatusUpdate(...) function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40561/#review107450 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m., An

Re: Review Request 40562: Added validation for 'uuid' field being present

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40562/#review107451 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 10:47 p.m., An

Review Request 40570: Modified stateUpdate(...) function to get the TaskStatus object by constant reference instead of copy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40570/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3476 https://issues.ap

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- (Updated Nov. 21, 2015, 12:21 a.m.) Review request for mesos, Ben Mahler, Isabe

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review107453 --- Ship it! src/slave/containerizer/mesos/isolators/network/port_map

Re: Review Request 40570: Modified stateUpdate(...) function to get the TaskStatus object by constant reference instead of copy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40570/#review107454 --- Ship it! Ship It! - Vinod Kone On Nov. 21, 2015, 12:21 a.m., An

Re: Review Request 39490: Always create non-IP egress filters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39490/#review107455 --- I'll fix this for you. - Jie Yu On Nov. 20, 2015, 11:36 p.m., Co

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/#review107452 --- src/slave/http.cpp (lines 318 - 322)

Re: Review Request 37336: Added `execute()` method to process::Subprocess

> On Nov. 20, 2015, 10:12 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 53-75 > > > > > > What's the motivation of storing this? Should the caller already have > > those informati

Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40367/#review107459 --- Ship it! Ship It! - Timothy Chen On Nov. 16, 2015, 9:31 p.m., G

Re: Review Request 39597: Add Newbie guide.

> On Nov. 6, 2015, 5:18 p.m., Vaibhav Khanduja wrote: > > docs/NewbieQuickStart.md, line 108 > > > > > > I am a "newbie" so was referring to your wip guide. I tried to run this > > command, but looks like it did not

Re: Review Request 39597: Add Newbie guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review107462 --- Diana are you still able to finish the comments? - Timothy Chen

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/ --- (Updated Nov. 21, 2015, 1:18 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

> On Nov. 21, 2015, 12:58 a.m., Vinod Kone wrote: > > src/slave/http.cpp, lines 318-322 > > > > > > indent by 4 spaces. > > > > also, it's hard to tell that None() is the argument for statusUpdate() > > and

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- (Updated Nov. 21, 2015, 1:45 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/ --- (Updated Nov. 21, 2015, 1:47 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review107466 --- Ship it! Ship It! - Timothy Chen On Nov. 4, 2015, 5:13 p.m., ha

Re: Review Request 39456: Documentation: added containerizer internals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review107467 --- Are you still working on this? This doesn't look complete to me? -

Re: Review Request 40375: [WIP] Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/ --- (Updated Nov. 21, 2015, 11:47 a.m.) Review request for mesos, Guangya Liu, Arte

Re: Review Request 39597: Add Newbie guide.

> On Nov. 6, 2015, 5:18 p.m., Vaibhav Khanduja wrote: > > docs/NewbieQuickStart.md, line 108 > > > > > > I am a "newbie" so was referring to your wip guide. I tried to run this > > command, but looks like it did not

Re: Review Request 40570: Modified stateUpdate(...) function to get the TaskStatus object by constant reference instead of copy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40570/#review107473 --- Ship it! Ship It! - Guangya Liu On 十一月 21, 2015, 12:21 a.m., An

Re: Review Request 40559: Added a wait() function to Subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/#review107475 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274, 4

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40247/#review107477 --- Patch looks great! Reviews applied: [40242, 40243, 40244, 40245, 4

<    1   2