Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Bernd Mathiske
> On Feb. 17, 2016, 2:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got results

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43608/#review119462 --- Are a couple of seconds wirth the extra code complexity?

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42842/#review119461 --- Ship it! Ship It! - Bernd Mathiske On Feb. 10, 2016, 9:49

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119436 --- src/tests/fetcher_cache_tests.cpp (lines 194 - 196)

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119434 --- src/tests/fetcher_cache_tests.cpp (line 197)

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
> On Feb. 17, 2016, 5:10 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 194 > > > > > > Can you please summary the discussion of you and bernd-mesos for why > > not using `Clock::settle()` so

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 17, 2016, 9:54 a.m.) Review request for mesos, Alexander

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119427 --- Ship it! Now without the checkpointing-related code which went

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119425 --- Patch looks great! Reviews applied: [43608, 42696, 43367]

<    1   2