Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Feb. 19, 2016, 2:24 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1530-1531 > > > > > > Let's pull at least the implementation out of the header. You may look > > at maintenance and quota

Re: Review Request 43716: Endpoint documents with title.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43716/ --- (Updated Feb. 21, 2016, 12:04 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review120065 --- It's Apache Mesos, and don't you forget it. :)

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120066 --- Patch looks great! Reviews applied: [43718] Passed command:

Re: Review Request 42710: Moved docker containerizer to docker folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42710/ --- (Updated 二月 21, 2016, 9:50 a.m.) Review request for mesos, Jie Yu and Timothy

Review Request 43809: Moved composing containerizer to composing folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43809/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4716

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120067 --- src/linux/fs.cpp (line 56)

Re: Review Request 43809: Moved composing containerizer to composing folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43809/#review120068 --- Patch looks great! Reviews applied: [42710, 43809] Passed

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 21, 2016, 12:24 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43718: Added fs::supported() function.

> On Feb. 21, 2016, 11:25 a.m., Klaus Ma wrote: > > src/linux/fs.cpp, line 56 > > > > > > Would you add comments on expected format in `/proc/systems`? It'll > > help other contributors to understand magic number

Re: Review Request 43761: Replaced an exit status numeral with the appropriate constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43761/#review120070 --- Ship it! I'll commit this, any reason you didn't do the

Re: Review Request 43762: Added a comment for `ShutdownProcess` in the executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43762/#review120071 --- Ship it! Thanks Alex, I'll get this in with an adjustment of

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Feb. 21, 2016, 9:49 p.m.) Review request for mesos and Michael Park.

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120072 --- Patch looks great! Reviews applied: [43718] Passed command:

Re: Review Request 37168: Added example for dynamic reservation features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Feb. 21, 2016, 10:07 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37531: Fix master CHECK failure if a framework uses duplicated task id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/#review120073 --- ping @jieyu/vinodkone. - Klaus Ma On Jan. 13, 2016, 10:06

Re: Review Request 37168: Added example for dynamic reservation features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review120074 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120075 --- Ship it! Ship It! - haosdent huang On Feb. 21, 2016, 12:24

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120076 --- src/tests/containerizer/fs_tests.cpp (line 48)

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

> On Feb. 18, 2016, 9:44 a.m., Qian Zhang wrote: > > I see you send TASK_KILLING once the killTask() is invoked. However, > > according to the description of MESOS-4140, we may need to send such status > > update after SIGTERM is sent to the task and before SIGKILL is sent. So > > maybe you

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

> On Feb. 21, 2016, 12:30 a.m., Ben Mahler wrote: > > src/launcher/executor.cpp, lines 460-469 > > > > > > Let's do this inside shutdown per my comment at the top. > > > > It's also not clear to me why the

Review Request 43814: Enabled volume propagation for docker volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43814/ --- Review request for mesos, Jie Yu and Timothy Chen. Bugs: MESOS-4717

Review Request 43816: Updated `/frameworks` endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/ --- Review request for mesos and Michael Park. Bugs: MESOS-4731

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/ --- (Updated Feb. 22, 2016, 2:10 a.m.) Review request for mesos and Jie Yu.

Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/ --- Review request for mesos and Michael Park. Bugs: MESOS-4731

Re: Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/ --- (Updated Feb. 22, 2016, 2:11 a.m.) Review request for mesos and Michael Park.

Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- Review request for mesos, Adam B and Neil Conway. Repository: mesos

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Feb. 19, 2016, 10:24 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1530-1531 > > > > > > Let's pull at least the implementation out of the header. You may look > > at maintenance and

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120091 --- docs/app-framework-development-guide.md (line 17)

Re: Review Request 43540: Added 'MesosCon 2016 CFP is now open!' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43540/ --- (Updated Feb. 22, 2016, 3:22 a.m.) Review request for mesos and Adam B.

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review120094 --- docs/configuration.md (line 1029)

Re: Review Request 43814: Enabled volume propagation for docker volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43814/#review120095 --- Patch looks great! Reviews applied: [43814] Passed command:

Re: Review Request 43814: Enabled volume propagation for docker volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43814/#review120098 --- Ship it! Ship It! include/mesos/mesos.proto (line 1498)

Re: Review Request 43807: Replaced with `~` in authentication.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43807/#review120099 --- docs/authentication.md (line 97)

Re: Review Request 43802: Wrapped TASK_LOST with `` in authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43802/#review120100 --- Ship it! Ship It! - haosdent huang On Feb. 21, 2016, 1:05

Re: Review Request 43580: Add indent to comments in protobuf_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43580/#review120102 --- Ship it! Ship It! - haosdent huang On Feb. 15, 2016, 4:16

Re: Review Request 43814: Enabled volume propagation for docker volume.

> On 二月 22, 2016, 3:53 a.m., haosdent huang wrote: > > include/mesos/mesos.proto, line 1498 > > > > > > I think we could not mix `rw` and propagation modes when mount, right? Yes, we cannot. I was now asking the

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 22, 2016, 6:37 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43817: Removed no-longer-used model functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/ --- (Updated Feb. 22, 2016, 7:13 a.m.) Review request for mesos and Michael Park.

Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43822/ --- Review request for mesos. Repository: mesos Description --- Updated

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

> On Feb. 17, 2016, 7:02 p.m., Kevin Klues wrote: > > In general, I prefer scripts with a bunch of helper functions and a compact > > main() that steps through each of them. I'm not sure what the general > > concensus for the Mesos code base is, but I generally find this easier to > > walk

Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43821/ --- Review request for mesos, Abhishek Dasgupta and Neil Conway. Bugs: MESOS-4547

Review Request 43826: Added 'Synchronized Statement in Mesos' blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43826/ --- Review request for mesos, Joerg Schad and Neil Conway. Repository: mesos

Re: Review Request 43552: Added a support/push-reviews.py script to push reviews upstream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43552/ --- (Updated Feb. 22, 2016, 4:52 a.m.) Review request for mesos, Artem

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/ --- (Updated Feb. 22, 2016, 6:29 a.m.) Review request for mesos, Guangya Liu,

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote: > > > > Adam B wrote: > Yongqiao, since Alex didn't get his review in before I committed the > patch, could you create a new patch addressing his feedback and link to it > from the comments here? Thanks. Thanks Adam and Alex, I

Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- Review request for mesos, Adam B and Alexander Rukletsov. Bugs: MESOS-4200

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43821/#review120110 --- Ship it! docs/high-availability-framework-guide.md (line 204)

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On Feb. 12, 2016, 3:43 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 543 > > > > > > Does label.value() return a Try? What kind of error do we expect from > > it? > > Abhishek Dasgupta wrote: >

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/ --- (Updated Feb. 22, 2016, 7:11 a.m.) Review request for mesos and Michael Park.

Re: Review Request 43489: KillTask introduces TASK_KILLING state.

> On Feb. 18, 2016, 1:44 a.m., Qian Zhang wrote: > > I see you send TASK_KILLING once the killTask() is invoked. However, > > according to the description of MESOS-4140, we may need to send such status > > update after SIGTERM is sent to the task and before SIGKILL is sent. So > > maybe you

Re: Review Request 43807: Replaced with `~` in authentication.md.

> On Feb. 22, 2016, 11:57 a.m., haosdent huang wrote: > > docs/authentication.md, line 97 > > > > > > I try `echo ~/a` in both bash and zsh. Seems it works for me. And do we > > have a jira ticket related to this?

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review120106 --- Patch looks great! Reviews applied: [43718] Passed command:

Re: Review Request 43817: Removed `model(const Framework&)` and `summarize(const Framework&)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43817/#review120119 --- Patch looks great! Reviews applied: [43816, 43817] Passed

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review120096 --- src/slave/flags.cpp (line 437)

Re: Review Request 43821: Updated the HA framweork guide for TASK_KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43821/#review120113 --- docs/high-availability-framework-guide.md (line 205)

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

> On 二月 12, 2016, 3:43 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 536 > > > > > > Seems like we're increasing trying to find docker versions in our code > > base. How about let's capture the docker