Re: Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases.

2016-03-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44828/#review123603 --- Patch looks great! Reviews applied: [44798, 44822, 44823, 44824,

Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged.

2016-03-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/ --- Review request for mesos and Jie Yu. Bugs: MESOS-2198 https://issues.apache

Re: Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged.

2016-03-14 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/#review123604 --- include/mesos/mesos.proto (line 626)

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

2016-03-14 Thread Jie Yu
> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 6:16 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44545: Separated standalone and zookeeper classes.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44546: Moved functions in promises to a common header file.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44547: Added functions in promises to the collect header.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44289: Added support for contender and detector modules.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44670: Added master_detector and master_contender flags.

2016-03-14 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-14 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- Review request for mesos and haosdent huang. Repository: mesos Description --

<    1   2   3