Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

> On 三月 18, 2016, 6:51 p.m., Vinod Kone wrote: > > Looks good to me. Couple of things before this can get committed. > > > > --> Have you sent an email to dev/user list about this backwards > > incompatible change? If not, you should. > > > > --> If users are depending on the return code

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 25, 2016, 12:20 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 438 > > > > > > Why do you need to get os::environment()? > > Qian Zhang wrote: > The reason

Review Request 45373: WIP: Checkpointed container external mount info during prepare().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45373/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Review Request 45275: Implemented prepare() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45275/ --- Review request for mesos. Repository: mesos Description --- Implemented

Review Request 45370: Implemented prepare() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 三月 28, 2016, 2:44 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 28, 2016, 10:21 a.m.) Review request for mesos, Ben Mahler,

Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway,

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 28, 2016, 10:09 a.m.) Review request for mesos, Ben Mahler,

Review Request 45369: Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45369/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway,

Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway,

Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway,

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 28, 2016, 9:53 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

> On March 26, 2016, 5:04 a.m., Vinod Kone wrote: > > Can you split this review into 2 reviews > > > > 1) Changes needed just for protobuf upgrade to 2.6.1 > > 2) Changes needed to make it compile for PPC Thanks, actually there is no specific changes for PPC, I just separated this patch for

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 28, 2016, 1:30 a.m.) Review request for mesos, Greg Mann, Shuai

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? I wanted to check that if files are directly written into

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- (Updated March 27, 2016, 10:05 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/#review125571 --- Patch looks great! Reviews applied: [45083, 45084, 45350, 45085,

Re: Review Request 45361: Remove rmdir_tests.cpp from CMake Windows build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45361/#review125569 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 45121: Implemented deletion for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/ --- (Updated March 27, 2016, 6:08 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45121: Implemented deletion for persistent volumes.

> On March 26, 2016, 12:37 a.m., Jie Yu wrote: > > src/slave/slave.cpp, line 2375 > > > > > > I would suggest we don't use CHECK here. We can just LOG(ERROR) if the > > deletion fails. Given the TODO above, we

Re: Review Request 45345: Added a python module to mock a CNI plugin and IPAM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45345/#review125567 --- Patch looks great! Reviews applied: [45345] Passed command:

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- (Updated March 27, 2016, 4:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45363: Add `MemorySubsystem ` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- (Updated March 27, 2016, 4:17 p.m.) Review request for mesos and Jie Yu.

Review Request 45363: Add `MemSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5045

Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45362/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5045

Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45364/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5045

Re: Review Request 45353: Migrate test cases for `cpuacct` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45353/ --- (Updated March 27, 2016, 4:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45354: Migrate `UserCgroupIsolatorTest` to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45354/ --- (Updated March 27, 2016, 4:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45352/ --- (Updated March 27, 2016, 4:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated March 27, 2016, 4:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45350/ --- (Updated March 27, 2016, 4:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45351: Migrate test cases for `cpu` subsystem to cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45351/ --- (Updated March 27, 2016, 4:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/ --- (Updated March 27, 2016, 4:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45087/ --- (Updated March 27, 2016, 4:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45085: Add cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated March 27, 2016, 4:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45083: Added a any mechanism for futures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/ --- (Updated March 27, 2016, 4:12 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45361: Remove rmdir_tests.cpp from CMake Windows build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45361/ --- (Updated Mar. 27, 2016, 4:03 p.m.) Review request for mesos. Repository:

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/#review125566 --- Patch looks great! Reviews applied: [45358] Passed command:

Re: Review Request 45345: Added a python module to mock a CNI plugin and IPAM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45345/ --- (Updated March 27, 2016, 2:52 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated March 27, 2016, 2:41 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated March 27, 2016, 2:40 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- (Updated March 27, 2016, 2:39 p.m.) Review request for mesos, Gilbert Song,

Review Request 45358: Improved overlay backend to make the rootfs writable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45358/ --- Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu. Repository: