Re: Review Request 42516: Add support for user-defined networks.

2016-03-29 Thread Ezra Silvera
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated March 29, 2016, 11:08 a.m.) Review request for mesos, Jie Yu and

Review Request 45419: Cleaned up ModuleManager.

2016-03-29 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/ --- Review request for mesos, Benjamin Bannier and Kapil Arya. Repository: mesos

Review Request 45423: Added note about preventing resource autodetection to documentation.

2016-03-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45423/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Repository:

Review Request 45424: Fixed a typo in "future.hpp".

2016-03-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45424/ --- Review request for mesos and Joerg Schad. Repository: mesos Description

Re: Review Request 45424: Fixed a typo in "future.hpp".

2016-03-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45424/#review125857 --- Ship it! Ship It! - Joerg Schad On March 29, 2016, 11:49

Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/#review125858 --- Patch looks great! Reviews applied: [44257, 45368, 45367]

Re: Review Request 45399: Fixed capitalization of Watchdog enum.

2016-03-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45399/#review125859 --- Ship it! Ship It! - Joris Van Remoortere On March 28, 2016,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-03-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review125864 --- 3rdparty/libprocess/src/process.cpp (line 2193)

Re: Review Request 45423: Added note about preventing resource autodetecting to documentation.

2016-03-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45423/ --- (Updated March 29, 2016, 2:02 p.m.) Review request for mesos, Joris Van

Re: Review Request 45423: Added note about preventing resource autodetection to documentation.

2016-03-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45423/#review125874 --- Fix it, then Ship it! docs/multiple-disk.md (line 31)

Re: Review Request 45435: Modified scheduler library to properly handle SSL connections.

2016-03-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45435/ --- (Updated March 30, 2016, 2:03 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 45439: Completed implementation of the Nvidia GPU isolator.

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45439/#review126000 --- Bad patch! Reviews applied: [45439, 44364, 44366, 44365, 44363,

Re: Review Request 45435: Modified scheduler library to properly handle SSL connections.

2016-03-29 Thread Anand Mazumdar
> On March 30, 2016, 12:23 a.m., Joseph Wu wrote: > > src/scheduler/scheduler.cpp, line 437 > > > > > > This flag is a `bool`, so we accept two forms: > > "1" and "true". > > > > See: > >

Re: Review Request 42516: Add support for user-defined networks.

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review125997 --- Patch looks great! Reviews applied: [42516] Passed command:

Review Request 45429: Added authentication to the '/registry' endpoint.

2016-03-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45429/ --- Review request for mesos, Adam B and Till Toenshoff. Bugs: MESOS-4933

Re: Review Request 45429: Added authentication to the '/registry' endpoint.

2016-03-29 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45429/ --- (Updated March 29, 2016, 5:05 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 42516: Add support for user-defined networks.

2016-03-29 Thread Ezra Silvera
> On March 29, 2016, 6:01 p.m., Avinash sridharan wrote: > > src/docker/docker.cpp, line 568 > > > > > > Maybe s/ Found .../Found multiple networks specified for this > > container. We can only attach docker

Re: Review Request 45455: Added test for recovering orphaned docker containers.

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45455/#review126037 --- Patch looks great! Reviews applied: [45453, 45454, 45455]

Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-4805

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- (Updated March 30, 2016, 1:35 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.

2016-03-29 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- (Updated March 30, 2016, 1:33 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 45398: Added CHANGELOG for python module changes.

2016-03-29 Thread Steve Niemitz
> On March 28, 2016, 9:55 p.m., Vinod Kone wrote: > > Can you also update the release guide > > (https://github.com/apache/mesos/blob/0af8bd6fe28e3cad82d7e05ae3e308c3b2febf29/docs/release-guide.md) > > regarding how to upload these new packages to pypi? As far as I can tell, only

Re: Review Request 45398: Added CHANGELOG for python module changes.

2016-03-29 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45398/ --- (Updated March 29, 2016, 2:21 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45419: Cleaned up ModuleManager.

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45419/#review125877 --- Patch looks great! Reviews applied: [45419] Passed command:

Re: Review Request 45440: Added some metrics to the long-lived-framework example.

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45440/#review126011 --- Patch looks great! Reviews applied: [45067, 45440] Passed

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

2016-03-29 Thread Qian Zhang
> On March 22, 2016, 11:37 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 644-645 > > > > > > These two CHECKS don't make sense. What if the plugin got deleted

Re: Review Request 44950: Add XFS disk isolator documentation.

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review126019 --- Bad patch! Reviews applied: [44950, 44949, 44948, 44947, 44946,

Review Request 45466: Removed the redundant `NULL` check when deleting `Credential`.

2016-03-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45466/ --- Review request for mesos, Klaus Ma, Neil Conway, and Vinod Kone. Repository:

Re: Review Request 45231: Removed the use of subprocess setup functions [2/7].

2016-03-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45231/#review126030 --- src/tests/containerizer/isolator_tests.cpp (line 166)

Re: Review Request 45231: Removed the use of subprocess setup functions [2/7].

2016-03-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45231/#review126031 --- @joerg84 Your works related to fork performance looks awesome,

<    1   2