Re: Review Request 47412: Windows: Use Winsock class in slave and containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47412/ --- (Updated May 23, 2016, 12:39 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47387: Stout: Implemented `fsync.hpp` for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47387/ --- (Updated May 23, 2016, 12:39 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47403/ --- (Updated May 23, 2016, 12:39 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47389/ --- (Updated May 23, 2016, 12:39 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47391: Stout: Removed warning in Windows implementation of `stat.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47391/ --- (Updated May 23, 2016, 12:39 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47409: Libprocess: Implemented `HANDLE` versions of file descriptor functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47409/ --- (Updated May 23, 2016, 12:39 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47404/ --- (Updated May 23, 2016, 12:39 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review134337 --- Patch looks great! Reviews applied: [47719] Passed command:

Re: Review Request 47717: Added test to verify that GPU auto-discovery works.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47717/#review134332 --- Patch looks great! Reviews applied: [47706, 47707, 47708, 47716,

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47707/#review134329 --- Did not go to detail for now, but post one early comment: It is

Re: Review Request 44154: Added appc_simple_discovery_uri_prefix to configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44154/ --- (Updated 五月 23, 2016, 9:41 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 47633: Checked if IPv6 module was loaded before disabling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/#review134323 --- Patch looks great! Reviews applied: [47633] Passed command:

Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone. Bugs:

Re: Review Request 46892: Postponed closing std streams of the docker task until after reaping.

> On Kvě. 17, 2016, 7:24 odp., Alexander Rukletsov wrote: > > src/docker/executor.cpp, line 308 > > > > > > `.await()` blocks the execution and synchronously wait for docker to > > terminate. I'd expect that during

Review Request 47717: Added test to verify that GPU auto-discovery works.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47717/ --- Review request for mesos, Benjamin Mahler and Vikrama Ditya. Bugs: MESOS-5257

Review Request 47716: Added auto-discovery to the NVidia GPU device isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47716/ --- Review request for mesos, Benjamin Mahler and Vikrama Ditya. Bugs: MESOS-5257

Re: Review Request 46892: Postponed closing std streams of the docker task until after reaping.

> On Kvě. 17, 2016, 7:24 odp., Alexander Rukletsov wrote: > > src/docker/executor.cpp, line 358 > > > > > > Why this change? Geeez, do I really have to repeat myself milion times? Without this change, the

Re: Review Request 47633: Checked if IPv6 module was loaded before disabling it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/ --- (Updated 五月 23, 2016, 7:55 a.m.) Review request for mesos, haosdent huang, Jie

Re: Review Request 47711: Added more verbose message when mesos command encouter error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47711/#review134319 --- Patch looks great! Reviews applied: [47711] Passed command:

Re: Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134318 --- site/Dockerfile (line 1)

Re: Review Request 47633: Networking: check if IPv6 is loaded before trying to disable it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47633/ --- (Updated 五月 23, 2016, 7:15 a.m.) Review request for mesos, haosdent huang, Jie

Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/ --- (Updated May 23, 2016, 7:06 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review134311 --- Patch looks great! Reviews applied: [45958, 45959, 45960, 45961,

Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

> On May 23, 2016, 6:12 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolator.hpp, lines 122-123 > > > > > > I think it is better to keep those two lines as comments for `status()` I would normally

Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/#review134308 --- src/slave/containerizer/mesos/isolator.hpp

<    1   2