Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/#review141401 --- Bad patch! Reviews applied: [49852, 49851, 49850, 49849, 49828,

Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Re: Review Request 49846: The SorterTest.RevocableResources should add total resources for slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49846/#review141395 --- Patch looks great! Reviews applied: [49846] Passed command:

Re: Review Request 49847: Added document about reopening old reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49847/#review141397 --- Patch looks great! Reviews applied: [49847] Passed command:

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 9, 2016, 8:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 9, 2016, 10:17 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49822: Implemented `CgroupsIsolatorProcess::notify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49822/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 9, 2016, 10:17 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49818: Implemented `CgroupsIsolatorProcess::createCgroup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49818/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/ --- (Updated July 9, 2016, 10:17 a.m.) Review request for mesos, Gilbert Song, Jie

Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Repository:

Re: Review Request 49815: Implemented `CgroupsIsolatorProcess::prepareHierarchy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49815/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49812: Added missing header `version.hpp` in `src/linux/perf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49812/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review141398 --- Patch looks great! Reviews applied: [49837, 49844] Passed

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/ --- (Updated July 9, 2016, 10:16 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 9, 2016, 3:54 p.m.) Review request for mesos and Benjamin

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review141396 --- Your patch cannot be applied with description exceed 72

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review141402 --- Bad patch! Reviews applied: [49855, 49854, 49853, 45573, 45472,

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated July 9, 2016, 6:44 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 49837: Fixed the flaky `MasterAPITest.Subscribe` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49837/#review141410 --- Ship it! Ship It! - Vinod Kone On July 8, 2016, 11:40 p.m.,

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review141411 --- src/master/master.hpp (line 1754)

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1754 > > > > > > should this be done in ~HttpConnection instead? hmm, `HttpConnection` is not meant to be used as an RAII object. We

Re: Review Request 49813: Added stubs for the unified cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review141404 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp

Re: Review Request 49847: Added document about reopening old reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49847/#review141416 --- Ship it! Ship It! - Joris Van Remoortere On July 9, 2016,

Re: Review Request 20496: gprof and gcov coverage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20496/#review141421 --- Closing this review due to inactivity. Please see our

Re: Review Request 19208: Move HTTP request logging to ProcessBase and add peer IP address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19208/#review141420 --- Closing this review due to inactivity. Please see our

Re: Review Request 22754: First part of the deactivate slaves mechanism - HTTP deactivate endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22754/#review141426 --- Closing this review due to inactivity. Please see our

Re: Review Request 24270: New MultiChildProcess test added to reap_tests.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24270/#review141427 --- Closing this review due to inactivity. Please see our

Re: Review Request 29718: Bug fix: Start the executor registration timer, only when the container has launched successfully

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29718/#review141442 --- Closing this review due to inactivity. Please see our

Re: Review Request 27923: Use Slave::getExecutorInfo() only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27923/#review141439 --- Closing this review due to inactivity. Please see our

Re: Review Request 20423: Moved validation visitors out of master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20423/#review141440 --- Closing this review due to inactivity. Please see our

Re: Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34669/#review141454 --- Closing this review due to inactivity. Please see our

Re: Review Request 34152: Master flag validation now supports zookeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34152/#review141453 --- Closing this review due to inactivity. Please see our

Re: Review Request 34139: AppC image discovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/#review141467 --- Closing this review due to inactivity. Please see our

Re: Review Request 34138: AppC hash computation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138/#review141466 --- Closing this review due to inactivity. Please see our

Re: Review Request 30643: Optionally specify executor for "mesos execute".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review141465 --- Closing this review due to inactivity. Please see our

Re: Review Request 31625: Fixed broken link in framework development guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31625/#review141495 --- Closing this review due to inactivity. Please see our

Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39514/#review141496 --- Closing this review due to inactivity. Please see our

Re: Review Request 39324: Updated protobuf::parse to handle JSON "null" values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39324/#review141494 --- Closing this review due to inactivity. Please see our

Re: Review Request 39678: Allow environment variables when lanuch Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39678/#review141498 --- Closing this review due to inactivity. Please see our

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/#review141497 --- Closing this review due to inactivity. Please see our

Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Re: Review Request 41864: Web UI Display Bug when starting lots of tasks with small cpu value on frameworks tab.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41864/#review141515 --- Closing this review due to inactivity. Please see our

Re: Review Request 41888: Fix sandbox browse UI has path which is not selectable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41888/#review141516 --- Closing this review due to inactivity. Please see our

Review Request 49862: Changes mesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Re: Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42580/#review141528 --- Closing this review due to inactivity. Please see our

Re: Review Request 42068: Porting 3rdparty on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42068/#review141527 --- Closing this review due to inactivity. Please see our

Re: Review Request 42069: Porting libprocess on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42069/#review141525 --- Closing this review due to inactivity. Please see our

Re: Review Request 42415: Added a roles field to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/#review141526 --- Closing this review due to inactivity. Please see our

Re: Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42686/#review141529 --- Closing this review due to inactivity. Please see our

Re: Review Request 36071: Add flow diagram for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/#review141548 --- Closing this review due to inactivity. Please see our

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review141549 --- Closing this review due to inactivity. Please see our

Re: Review Request 43814: Enabled volume propagation for docker volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43814/#review141550 --- Closing this review due to inactivity. Please see our

Re: Review Request 43041: Update Master to send revocable resources in separate offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43041/#review141546 --- Closing this review due to inactivity. Please see our

Re: Review Request 43593: Add test for spliting revocable resources in separate offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43593/#review141547 --- Closing this review due to inactivity. Please see our

Re: Review Request 43964: CMAKE: Add leveldb library (3rdparty project).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43964/#review141551 --- Closing this review due to inactivity. Please see our

Re: Review Request 44338: Added URI test for HDFS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44338/#review141567 --- Closing this review due to inactivity. Please see our

Re: Review Request 44337: Updated utils for URI constructor streaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44337/#review141568 --- Closing this review due to inactivity. Please see our

Re: Review Request 45505: WIP : Providing starting implementation for appc runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45505/#review141579 --- Closing this review due to inactivity. Please see our

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/#review141581 --- Closing this review due to inactivity. Please see our

Re: Review Request 45567: Added an interface to insert `iptables` rules in linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45567/#review141580 --- Closing this review due to inactivity. Please see our

Re: Review Request 36607: Add ppc64le architecture support for glog, libev, and protobuf

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36607/#review141471 --- Closing this review due to inactivity. Please see our

Re: Review Request 36608: Add ppc64le architecture support for leveldb and zookeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36608/#review141472 --- Closing this review due to inactivity. Please see our

Re: Review Request 29437: Bug fix: Start the executor registration timer, only when the container has launched successfully

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29437/#review141469 --- Closing this review due to inactivity. Please see our

Re: Review Request 36428: Remove erroneous code for isolator modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36428/#review141468 --- Closing this review due to inactivity. Please see our

Re: Review Request 34141: AppC provsioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34141/#review141470 --- Closing this review due to inactivity. Please see our

Re: Review Request 40054: Fix fetch parsing problem for URL with query.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/#review141501 --- Closing this review due to inactivity. Please see our

Re: Review Request 40513: [DO NOT COMMIT] Parameterizes existing scheduler tests to run with varieties of SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40513/#review141505 --- Closing this review due to inactivity. Please see our

Re: Review Request 40046: Include SSL related environment variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40046/#review141500 --- Closing this review due to inactivity. Please see our

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40340/#review141504 --- Closing this review due to inactivity. Please see our

Re: Review Request 38977: Added reason for declineOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38977/#review141499 --- Closing this review due to inactivity. Please see our

Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40146/#review141503 --- Closing this review due to inactivity. Please see our

Re: Review Request 40284: Disabled SSL for launching mesos executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40284/#review141502 --- Closing this review due to inactivity. Please see our

Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review141530 --- Closing this review due to inactivity. Please see our

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated July 10, 2016, 1 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 10, 2016, 1 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 10, 2016, 1 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review141531 --- Closing this review due to inactivity. Please see our

Re: Review Request 44001: CMake: Add MasterConfigure for master executable build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44001/#review141560 --- Closing this review due to inactivity. Please see our

Re: Review Request 41760: Add initialization method to Anonymous class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41760/#review141563 --- Closing this review due to inactivity. Please see our

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review141562 --- Closing this review due to inactivity. Please see our

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42100/#review141565 --- Closing this review due to inactivity. Please see our

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/#review141572 --- Closing this review due to inactivity. Please see our

Re: Review Request 44531: Fixed parsing network ip address with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review141573 --- Closing this review due to inactivity. Please see our

Re: Review Request 43807: Replaced with `~` in authentication.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43807/#review141571 --- Closing this review due to inactivity. Please see our

Re: Review Request 43293: Ignored invalid env vars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43293/#review141570 --- Closing this review due to inactivity. Please see our

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review141569 --- Closing this review due to inactivity. Please see our

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43471/#review141582 --- Closing this review due to inactivity. Please see our

Re: Review Request 49688: Added cmake build for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 10, 2016, 1:49 a.m.) Review request for mesos, Alex Clemmer and

  1   2   3   >