Re: Review Request 54486: Added default values for all required IOSwitchboardServerFlags.

> On Dec. 8, 2016, 12:13 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/io/switchboard_main.cpp, lines 71-76 > > > > > > Using sentinel values in the parameter domain as default values seems > >

Re: Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54636/#review158798 --- Patch looks great! Reviews applied: [54636] Passed command:

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

> On Dec. 7, 2016, 12:26 a.m., Avinash sridharan wrote: > > docs/configuration.md, line 1606 > > > > > > Just checking: Isn't the `configuration.md` auto-generated? > >

Re: Review Request 54535: WIP: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54535/#review158794 --- Looks good, just some comment nits, and a recommendation to move

Re: Review Request 54538: WIP: Enabled fine grained authorization for the getContainers API Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/#review158795 --- src/slave/http.cpp (line 1833)

Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch board server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54637/#review158816 --- Ship it! Do we know why the build failed? - Kevin Klues On

Re: Review Request 52349: Add protobuf messages for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/#review158819 --- Fix it, then Ship it! Ship It! include/mesos/oci/spec.proto

Re: Review Request 54493: Turned off Master's auth flags tests when platform doesn't support it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54493/ --- (Updated Dec. 12, 2016, 2:53 a.m.) Review request for mesos, Andrew

Re: Review Request 54643: Added union assignment operator in hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54643/#review158824 --- Patch looks great! Reviews applied: [54643] Passed command:

Review Request 54645: MESOS-6644: Fix failure of large message devolution.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54645/ --- Review request for mesos. Repository: mesos Description --- MESOS-6644:

Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch board server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54637/#review158820 --- Ship it! Ship It! - Jie Yu On Dec. 11, 2016, 4:46 a.m.,

Re: Review Request 54627: Updated address of 'http::connect()' with http scheme for SSL support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54627/#review158822 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (lines

Re: Review Request 54535: WIP: Added authorization actions VIEW_CONTAINERS and SET_LOG_LEVEL.

> On Dec. 9, 2016, 10:52 a.m., Adam B wrote: > > include/mesos/authorizer/acls.proto, lines 355-356 > > > > > > "The list of roles whose container metadata the principal can see." Not using roles anymore. We are

Re: Review Request 54631: Windows: Disambiguated `os::write` by adding another overload.

> On Dec. 11, 2016, 3:40 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [54631, 54618, 54611, 54493, 54490, 54489, 54519, 54470, > > 54462, 54453, 54446, 54415, 54395, 52778, 53552, 53551, 53550, 54324, > > 53706, 52624, 52625, 52972, 52544, 52364] > > > > Failed

Review Request 54643: Added union assignment operator in hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54643/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Repository: mesos

Re: Review Request 54486: Added default values for all required IOSwitchboardServerFlags.

> On Dec. 8, 2016, 11:13 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/io/switchboard_main.cpp, lines 71-76 > > > > > > Using sentinel values in the parameter domain as default values seems > >

Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch board server.

> On Dec. 12, 2016, 2:20 a.m., Kevin Klues wrote: > > Do we know why the build failed? rebase issue. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54637/#review158816

Re: Review Request 52349: Add protobuf messages for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/ --- (Updated Dec. 11, 2016, 10:15 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/ --- (Updated Dec. 11, 2016, 10:16 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/#review157976 --- src/master/allocator/mesos/hierarchical.cpp (lines 722 - 727)

Re: Review Request 54639: Implemented the 'create()' method of OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54639/#review158800 --- Patch looks great! Reviews applied: [52349, 52379, 54638, 52382,

Review Request 54639: Implemented the 'create()' method of OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54639/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6681

Re: Review Request 52382: Added stubs for OCI store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52382/ --- (Updated Dec. 11, 2016, 10:19 p.m.) Review request for mesos and Jie Yu.

Review Request 54638: Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54638/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6681

Re: Review Request 54637: Fixed EOF bug when tty is enabled in switch board server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54637/#review158799 --- Bad patch! Reviews applied: [54637, 54620] Failed command:

Re: Review Request 54281: Added new test for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54281/ --- (Updated Dec. 12, 2016, 12:33 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 54508: Added a TTY test for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54508/ --- (Updated Dec. 12, 2016, 12:33 a.m.) Review request for mesos and Anand

Re: Review Request 54516: Removed the TODO in AgentAPITest.AttachContainerOutputFailure test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54516/ --- (Updated Dec. 12, 2016, 12:34 a.m.) Review request for mesos and Anand

Re: Review Request 54545: Cleaned up expectations in api_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54545/ --- (Updated Dec. 12, 2016, 12:32 a.m.) Review request for mesos and Anand

Re: Review Request 54544: Added AgentAPITest.LaunchNestedContainerSessionDisconnected.

> On Dec. 10, 2016, 6:50 p.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, lines 4047-4049 > > > > > > Can you file an issue for this so that it's tracked? https://issues.apache.org/jira/browse/MESOS-6778

Re: Review Request 54544: Added AgentAPITest.LaunchNestedContainerSessionDisconnected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54544/ --- (Updated Dec. 12, 2016, 12:34 a.m.) Review request for mesos, Anand Mazumdar