Re: Review Request 59891: Windows: Use `cmd /C exit 1` instead of `false`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/#review178554 --- Ship it! Ship It! - Joseph Wu On June 7, 2017, 12:50 p.m.,

Re: Review Request 59865: Fixed conversion warning in `duration.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59865/#review178553 --- Ship it! Ship It! - Joseph Wu On June 7, 2017, 1 p.m.,

Re: Review Request 59817: Changed "future discarded" log message from error to info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59817/#review178551 --- Ship it! Ship It! - Joseph Wu On June 5, 2017, 12:26 p.m.,

Re: Review Request 59500: Added Windows ReviewBot launch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59500/#review178550 --- Ship it! Needs some more newlines between comments (I'll add

Re: Review Request 59466: Add metrics check to Fetcher tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59466/#review178546 --- Ship it! Ship It! - Joseph Wu On June 9, 2017, 11:56 a.m.,

Re: Review Request 59467: Document new Fetcher metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59467/#review178547 --- Ship it! Ship It! - Joseph Wu On June 9, 2017, 11:56 a.m.,

Review Request 60290: Handle EINVAL from the capabilities version check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60290/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- (Updated June 21, 2017, 1:48 p.m.) Review request for mesos, Dmitry Zhuk, Ilya

Review Request 60288: Fix ambient capability tests on older systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60288/ --- Review request for mesos, Alexander Rukletsov and Jie Yu. Repository: mesos

Review Request 60287: Remove unnecessary test logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60287/ --- Review request for mesos, Alexander Rukletsov and Jie Yu. Repository: mesos

Re: Review Request 60284: Removed unused `convertResourceFormat` for `Operation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60284/#review178537 --- src/common/resources_utils.cpp Line 198 (original)

Re: Review Request 60283: Fixed the uses of `convertResourceFormat` with `upgradeResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60283/#review178536 --- src/master/master.cpp Lines 4234 (patched)

Re: Review Request 60282: Introduced `upgradeResources` which also validates the resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60282/#review178535 --- src/common/resources_utils.cpp Lines 271 (patched)

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review178534 --- Someone correct me if I'm wrong, but I don't think we need this

Re: Review Request 60281: Added the adjusted `TaskInfo` into the `Operation` to be sent out.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60281/#review178533 --- Can we write a unit test for this change? - Neil Conway On

Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- Review request for mesos, Jie Yu, James Peach, and Zhitao Li. Bugs: MESOS-7703

Re: Review Request 59855: Set the fetcher cache size at construction time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59855/#review178528 --- Ship it! Ship It! - Joseph Wu On June 6, 2017, 1:20 p.m.,

Review Request 60284: Removed unused `convertResourceFormat` for `Operation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60284/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 60283: Fixed the uses of `convertResourceFormat` with `upgradeResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60283/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 60282: Introduced `upgradeResources` which also validates the resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60282/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 60281: Added the adjusted `TaskInfo` into the `Operation` to be sent out.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60281/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Re: Review Request 59854: Make additional Fetcher and FetcherProcess methods const.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59854/#review178524 --- Ship it! Ship It! - Joseph Wu On June 6, 2017, 1:19 p.m.,

Re: Review Request 60252: Fixed a bug that causes segfault in ProcessManager::finalize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60252/#review178522 --- Ship it! I agree this makes the finalization logic safer, but

Review Request 60279: Add constructor for ObjectApprover::Object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60279/ --- Review request for mesos, Anand Mazumdar, Greg Mann, and Vinod Kone. Bugs:

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

> On May 17, 2017, 4:08 p.m., Adam B wrote: > > src/master/http.cpp > > Lines 3524 (patched) > > > > > > `futures` is an over-vague variable name, especially since neither are > > Futures by this point. Can we do

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

> On May 17, 2017, 4:29 p.m., Adam B wrote: > > Seems like we're adding even more duplicate code into this v1 clone of > > `roles()`. Can you find a way to reduce the redundance? OK, let me take look and may submit some follow-up patches for it. - Jay

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/ --- (Updated June 22, 2017, 2:02 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated June 22, 2017, 2:01 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/ --- (Updated June 22, 2017, 2:01 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- (Updated June 22, 2017, 2 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 58095: Refactored `Master::Http::roles` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated June 22, 2017, 1:57 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- (Updated June 21, 2017, 10:27 a.m.) Review request for mesos, Dmitry Zhuk,

Re: Review Request 59746: Separated discarded and failed cases for container launch.

> On June 2, 2017, 4:37 p.m., Jie Yu wrote: > > src/slave/slave.cpp > > Line 5147 (original), 5147 (patched) > > > > > > Can you explain to me in what scenario, the `future` will be in > > DISCARDED state? who

Re: Review Request 60103: Changed variable name _ack to statusUpdateAck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60103/#review178509 --- Ship it! In the future please always keep the review title up

Re: Review Request 60105: Added helper method recoverSlaveState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178388 --- PTAL at these comments but I realize for this review it's

<    1   2