Re: Review Request 65624: Added fetcher tests for `stderr` output.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review197400 --- Patch looks great! Reviews applied: [65397, 65398, 65399, 65400,

Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

> On Feb. 13, 2018, 9:38 a.m., Vinod Kone wrote: > > Can you add tests for this in a subsequent review please? Yes, here it is: https://reviews.apache.org/r/65630/ > On Feb. 13, 2018, 9:38 a.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 1109- (patched) > >

Re: Review Request 65587: Added hash function for mesos::UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65587/#review197393 --- Ship it! Ship It! - Jan Schlicht On Feb. 9, 2018, 6:27

Re: Review Request 65518: Reaped the container process directly in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65518/#review197395 --- Patch looks great! Reviews applied: [65518] Passed command:

Review Request 65630: Updated the test `ROOT_PersistentResources` to check `/files` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65630/ --- Review request for mesos, Gilbert Song and Vinod Kone. Bugs: MESOS-8565

Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65588/#review197394 --- Thanks for cleaning this up! Looks great, only minor thing that

Re: Review Request 65590: Added helper function to determine provider ID of a conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65590/#review197397 --- src/common/resources_utils.cpp Lines 290-311 (patched)

Re: Review Request 65161: Removed some redundant `get` calls in libprocess.

> On Feb. 12, 2018, 8:09 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/include/process/gtest.hpp > > Lines 429-430 (original), 429-430 (patched) > > > > > > Ha! It's funny it caught the one in the

Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65570/#review197387 --- PASS: Mesos patch 65570 was successfully built and tested.

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197388 --- PASS: Mesos patch 65593 was successfully built and tested.

Re: Review Request 65630: Updated the test `ROOT_PersistentResources` to check `/files` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65630/#review197396 --- PASS: Mesos patch 65630 was successfully built and tested.

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197410 --- src/master/master.cpp Line 7295 (original), 7329 (patched)

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated Feb. 13, 2018, 3:44 p.m.) Review request for mesos, haosdent huang

Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Vinod Kone. Bugs:

Re: Review Request 65617: Windows: Fixed problems with Hadoop URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65617/ --- (Updated Feb. 13, 2018, 4:52 p.m.) Review request for mesos, Andrew

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197421 --- Ship it! Ship It! - Gaston Kleiman On Feb. 13, 2018, 7:52

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197414 --- PASS: Mesos patch 65637 was successfully built and tested.

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197418 --- PASS: Mesos patch 52064 was successfully built and tested.

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197419 --- Ship it! Ship It! - Gilbert Song On Feb. 13, 2018, 7:52

Re: Review Request 65637: Destroyed nested container on `attachContainerOutput` failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65637/#review197426 --- Ship it! Ship It! - Greg Mann On Feb. 13, 2018, 3:52 p.m.,

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/ --- (Updated Feb. 13, 2018, 8:05 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

> On Feb. 8, 2018, 8:22 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 2186 (patched) > > > > > > s/Leader detector indicated no master elected/No master was elected/ > > > > More importantly,

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review197422 --- PASS: Mesos patch 64211 was successfully built and tested.

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review197430 --- PASS: Mesos patch 65571 was successfully built and tested.

Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/ --- Review request for mesos, Jie Yu and Joseph Wu. Bugs: MESOS-8567

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review197432 --- Patch looks great! Reviews applied: [52064] Passed command:

Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review197434 --- src/master/master.cpp Lines 2182-2185 (patched)

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/#review197439 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/ --- (Updated Feb. 13, 2018, 10:18 p.m.) Review request for mesos, James DeFelice,

Re: Review Request 65570: Attached/detached volume directory for task which has volume specified.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65570/ --- (Updated Feb. 14, 2018, 11:09 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197470 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 4841

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/ --- (Updated Feb. 13, 2018, 7:33 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65448: Added a test to ensure master removes executors that never launched.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65448/#review197475 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 4673

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/#review197447 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/ --- (Updated Feb. 13, 2018, 11:14 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 65626: Added mock method for `__run()` in mock slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65626/#review197461 --- Ship it! Ship It! - Greg Mann On Feb. 13, 2018, 6:25 a.m.,

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197476 --- PASS: Mesos patch 65593 was successfully built and tested.

Re: Review Request 65593: Added tests to check executor that failed to launch is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197478 --- Patch looks great! Reviews applied: [65445, 65504, 65446, 65449,