Re: Review Request 66843: Enabled per-framework metrics in the allocator.

2018-07-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66843/#review206229 --- Ship it! Ship It! - Gastón Kleiman On July 17, 2018, 6:43

Review Request 67968: Added logging to some containerizer destroy paths.

2018-07-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67968/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 66820: Added per-framework 'subscribed' metric and helpers.

2018-07-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/#review206223 --- Ship it! Ship It! - Gastón Kleiman On July 17, 2018, 6:33

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

2018-07-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206203 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Line 495

Re: Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

2018-07-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67952/#review206208 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67897: Updated two tests to verfiy freezer subsystem.

2018-07-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67897/#review206221 --- Ship it! Ship It! - Gilbert Song On July 12, 2018, 7:17

Re: Review Request 66855: Changed the 'capacity_' member of 'BoundedHashMap' to non-const.

2018-07-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66855/#review206228 --- Ship it! Ship It! - Gastón Kleiman On July 17, 2018, 6:44

Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67896/#review206219 --- Fix it, then Ship it!

Re: Review Request 67962: Enabled per-framework metrics in the master.

2018-07-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67962/#review206222 --- Ship it! Ship It! - Gastón Kleiman On July 17, 2018, 6:23

Re: Review Request 67968: Added logging to some containerizer destroy paths.

2018-07-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67968/#review206220 --- PASS: Mesos patch 67968 was successfully built and tested.

Re: Review Request 67812: Added per-framework offer metrics.

2018-07-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67812/#review206227 --- Ship it! Ship It! - Gastón Kleiman On July 17, 2018, 6:34

Re: Review Request 67809: Added per-framework metrics for scheduler events.

2018-07-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67809/#review206226 --- Fix it, then Ship it! src/master/master.hpp Lines 2473

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-18 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206201 --- Didn't look at the patch, but some time ago I posted a patchset

Review Request 67965: Optimized ranges subtraction operation.

2018-07-18 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67965/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9086

Re: Review Request 67931: Support Image Manifest Version 2 Schema 2.

2018-07-18 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/ --- (Updated July 18, 2018, 9:27 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67930: Get tests ready for Windows UCR development.

2018-07-18 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/ --- (Updated July 18, 2018, 9:27 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-18 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/ --- (Updated July 18, 2018, 9:27 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

2018-07-18 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- (Updated July 18, 2018, 8:36 a.m.) Review request for mesos, Andrew

Re: Review Request 67503: Added support helper for fetching review ids.

2018-07-18 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated July 18, 2018, 8:50 a.m.) Review request for mesos, Andrew

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

2018-07-18 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated July 18, 2018, 8:50 a.m.) Review request for mesos, Andrew

Re: Review Request 67504: Added support script to post build results.

2018-07-18 Thread Dragos Schebesch via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated July 18, 2018, 8:50 a.m.) Review request for mesos, Andrew

Review Request 67963: Added missing header to libprocess build.

2018-07-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67963/ --- Review request for mesos, Benjamin Hindman and Dario Rexin. Repository: mesos

Re: Review Request 67963: Added missing header to libprocess build.

2018-07-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67963/#review206194 --- Ship it! Ship It! - Alexander Rukletsov On July 18, 2018,

Re: Review Request 67823: Added a master benchmark test for metrics.

2018-07-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67823/#review206200 --- Bad patch! Reviews applied: [67823, 67187, 67878, 66870, 66856,

Re: Review Request 67776: Added per-framework metrics for scheduler calls.

2018-07-18 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67776/#review206225 --- Ship it! Ship It! - Gastón Kleiman On July 17, 2018, 6:42

Re: Review Request 67965: Optimized ranges subtraction operation.

2018-07-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67965/#review206204 --- PASS: Mesos patch 67965 was successfully built and tested.

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206197 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

2018-07-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review206196 --- PASS: Mesos patch 67505 was successfully built and tested.