date:20180828

Re: Review Request 68548: Added allocator benchmark test harness.

2018-08-28 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68548/#review208063
---

Glad to see this being added! Thank you!

I did a pass on the test harness. Will look into the test after the harness is
updated.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 58 (patched)

Do we need this? Can you audit other "using/include" and remove any that
are not needed?

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 82 (patched)

`set` would enable us to benchmark multi-role frameworks.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 85 (patched)

Take reference?

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 91 (patched)

We can use `CHECK_NOTERROR` instead of the unguarded `get`.

Moreover, I think it is more flexible to just take a `Resource` object
here, leaving the parsing or whatever to the caller. For non-trivial resource
objects e.g. involving persistent volume, they are more likely to already be
resource objects instead of a plain string.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 109 (patched)

ditto resources object.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 135-136 (patched)

Comparing to the original test harness, we probably want to control more
things e.g. random allocator and other flag values in the future.

I suggest selectively keep/expose several fields such as interval, sorter
type and etc. explicitly instead of keeping a default master flag. See my
comments regarding `initializeCluster` below.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 155 (patched)

Are we relying on callers to name their frameworks ...%pid? Then this is
very fragile. One solution is to just concatenate with `_#` and document it
well. I think "nextFrameworkId" is used for that?

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 160 (patched)

ditto

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 162 (patched)

If we `push_back` last, we can std::move.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 167 (patched)

I would expect `frameworkTasksLaunched` tracks
the number of "launched tasks", not "tasks to launch".

Can you also add some comments to the fields whose meaning is not
immediately obvious?

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 183 (patched)

ditto

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 190 (patched)

We can std::move here, even in the test, savings are savings:)

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 197 (patched)

I think this TODO is no longer relavent.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 199-200 (patched)

As mentioned above, let's expose more knobs here. For now, maybe just
allocator type, allocation interval, offercallback and any other that are
currently being touched.

This will likely make the initialize function signature ugly. It is
probably better to introduce a flag (maybe utilize the `BenchmarkConfig`
below?). You probably can come up with a better solution.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 220 (patched)

ah, one thing I forget to mention in the original patch. This vector here
is fragile. It will be concurrently accessed by both allocator actor and the
test actor. Like the test base, let's use an asynchronous queue here.

https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L282

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 241 (patched)

Create frameworks and agents. (Or just remove the comment).

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 345-346 (patched)

The meaning of these fields are not obvious, adding some comments would be
helpful.

src/tests/hierarchical_allocator_benchmarks.cpp
Lines 350 (patched)

hmm, just to understand the test

Re: Review Request 68553: Set 'Connection: close' in the master's streaming API responses.

2018-08-28 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68553/#review208076
---



PASS: Mesos patch 68553 was successfully built and tested.

Reviews applied: `['68553']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2256/mesos-review-68553

- Mesos Reviewbot Windows


On Aug. 29, 2018, 2:03 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68553/
> ---
> 
> (Updated Aug. 29, 2018, 2:03 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-9189
> https://issues.apache.org/jira/browse/MESOS-9189
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We've seen some HTTP intermediaries (e.g. ELB) decide to re-use
> connections to mesos as an optimization to avoid re-connection
> overhead. As a result, when the end-client of the streaming API
> disconnects from the intermediary, the intermediary leaves the
> connection to Mesos open in an attempt to re-use the connection
> for another request once the response completes. Mesos then thinks
> that the subscriber never disconnected and the intermediary happily
> continues to read the streaming events even though there's no
> end-client.
> 
> To help indicate to intermediaries that the connection SHOULD NOT
> be re-used, we can set the 'Connection: close' header for streaming
> API responses. It may not be respected (since the language seems to
> be SHOULD NOT), but some intermediaries may respect it and close the
> connection if the end-client disconnects.
> 
> Note that libprocess' http server currently doesn't close the the
> connection based on a handler setting this header, but it doesn't
> matter here since the master's operator / scheduler and agent's
> executor streaming API responses are infinite.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97 
> 
> 
> Diff: https://reviews.apache.org/r/68553/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified headers make it through:
> 
> ```
> $ telnet 10.0.49.2 5050
> Trying 10.0.49.2...
> Connected to 10.0.49.2.
> Escape character is '^]'.
> POST /master/api/v1 HTTP/1.1
> Content-Type: application/json
> Accept: application/json
> Content-Length: 20
> 
> {"type":"SUBSCRIBE"}
> HTTP/1.1 200 OK
> Transfer-Encoding: chunked
> Content-Type: application/json
> Date: Wed, 29 Aug 2018 01:58:34 GMT
> Connection: close
> 
> 9e
> 154
> {"type":"SUBSCRIBED","subscribed":{"get_state":{"get_tasks":{},"get_executors":{},"get_frameworks":{},"get_agents":{}},"heartbeat_interval_seconds":15.0}}
> 17
> 20
> {"type":"HEARTBEAT"}
> ```
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 68553: Set 'Connection: close' in the master's streaming API responses.

2018-08-28 Thread Benjamin Mahler


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68553/
---

Review request for mesos, Gastón Kleiman and Vinod Kone.


Bugs: MESOS-9189
https://issues.apache.org/jira/browse/MESOS-9189


Repository: mesos


Description
---

We've seen some HTTP intermediaries (e.g. ELB) decide to re-use
connections to mesos as an optimization to avoid re-connection
overhead. As a result, when the end-client of the streaming API
disconnects from the intermediary, the intermediary leaves the
connection to Mesos open in an attempt to re-use the connection
for another request once the response completes. Mesos then thinks
that the subscriber never disconnected and the intermediary happily
continues to read the streaming events even though there's no
end-client.

To help indicate to intermediaries that the connection SHOULD NOT
be re-used, we can set the 'Connection: close' header for streaming
API responses. It may not be respected (since the language seems to
be SHOULD NOT), but some intermediaries may respect it and close the
connection if the end-client disconnects.

Note that libprocess' http server currently doesn't close the the
connection based on a handler setting this header, but it doesn't
matter here since the master's operator / scheduler and agent's
executor streaming API responses are infinite.


Diffs
-

  src/master/http.cpp e074a93666d82944774e7b0c3fa32d7021d93c97 


Diff: https://reviews.apache.org/r/68553/diff/1/


Testing
---

Manually verified headers make it through:

```
$ telnet 10.0.49.2 5050
Trying 10.0.49.2...
Connected to 10.0.49.2.
Escape character is '^]'.
POST /master/api/v1 HTTP/1.1
Content-Type: application/json
Accept: application/json
Content-Length: 20

{"type":"SUBSCRIBE"}
HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: application/json
Date: Wed, 29 Aug 2018 01:58:34 GMT
Connection: close

9e
154
{"type":"SUBSCRIBED","subscribed":{"get_state":{"get_tasks":{},"get_executors":{},"get_frameworks":{},"get_agents":{}},"heartbeat_interval_seconds":15.0}}
17
20
{"type":"HEARTBEAT"}
```


Thanks,

Benjamin Mahler

Re: Review Request 68068: Added tests for task metadata GC using the default executor.

2018-08-28 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review208075
---



PASS: Mesos patch 68068 was successfully built and tested.

Reviews applied: `['68065', '68066', '68067', '68095', '68068']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2255/mesos-review-68068

- Mesos Reviewbot Windows


On Aug. 22, 2018, 6:33 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> ---
> 
> (Updated Aug. 22, 2018, 6:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds two tests that launch a long-lived and short-lived task
> on the same executor.  The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
> 
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
> 
> One existing test is modified due to the extra GC event from
> task metadata.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 
>   src/tests/slave_recovery_tests.cpp 9710518db30ce3826284f3b7e323bdd9aa207831 
> 
> 
> Diff: https://reviews.apache.org/r/68068/diff/4/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> (Other platforms pending...)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-28 Thread Liangyu Zhao via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68454/
---

(Updated Aug. 28, 2018, 11:26 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie 
Yu, Joseph Wu, and Qian Zhang.


Bugs: MESOS-9159
https://issues.apache.org/jira/browse/MESOS-9159


Repository: mesos


Description
---

DockerFetcher now fetches both V2S1 and V2S2 manifests to save on
disk when agent is running on Windows. Linux part of the code in
agent is unchanged. In addition to fetching from DockerHub,
DockerFetcher now supports fetching from foreign URLs provided in
V2S2 Docker image manifest.


Diffs (updated)
-

  src/uri/fetchers/docker.hpp 7a6193dd75dc10846f52cb039f6a162cc8805c16 
  src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 


Diff: https://reviews.apache.org/r/68454/diff/5/

Changes: https://reviews.apache.org/r/68454/diff/4-5/


Testing
---


Thanks,

Liangyu Zhao

Re: Review Request 68542: De-duplicated identical read-only requests to master.

2018-08-28 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68542/#review208074
---



Patch looks great!

Reviews applied: [68542]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 28, 2018, 4:54 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68542/
> ---
> 
> (Updated Aug. 28, 2018, 4:54 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under certain assumptions, we can safely assume that
> two requests with the same parametesr to the same endpoint
> will return the same result. This is most noticeable for
> the `/state` endpoint.
> 
> In this case, we only need to compute the response once.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 
> 
> 
> Diff: https://reviews.apache.org/r/68542/diff/1/
> 
> 
> Testing
> ---
> 
> Accessed `localhost:5050/state` on master including these changes.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

2018-08-28 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68550/#review208073
---



PASS: Mesos patch 68550 was successfully built and tested.

Reviews applied: `['68550']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2254/mesos-review-68550

- Mesos Reviewbot Windows


On Aug. 28, 2018, 9:46 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68550/
> ---
> 
> (Updated Aug. 28, 2018, 9:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Greg Mann, 
> and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 997154a8f6c30b7d74ff5e67fb3efa0bc2b94de7 
> 
> 
> Diff: https://reviews.apache.org/r/68550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-28 Thread Liangyu Zhao via Review Board


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68454/
---

(Updated Aug. 28, 2018, 10:38 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, Jie 
Yu, Joseph Wu, and Qian Zhang.


Bugs: MESOS-9159
https://issues.apache.org/jira/browse/MESOS-9159


Repository: mesos


Description
---

DockerFetcher now fetches both V2S1 and V2S2 manifests to save on
disk when agent is running on Windows. Linux part of the code in
agent is unchanged. In addition to fetching from DockerHub,
DockerFetcher now supports fetching from foreign URLs provided in
V2S2 Docker image manifest.


Diffs (updated)
-

  src/uri/fetchers/docker.hpp 7a6193dd75dc10846f52cb039f6a162cc8805c16 
  src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 


Diff: https://reviews.apache.org/r/68454/diff/4/

Changes: https://reviews.apache.org/r/68454/diff/3-4/


Testing
---


Thanks,

Liangyu Zhao

Re: Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

2018-08-28 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68550/#review208072
---


Ship it!




Ship It!

- Jie Yu


On Aug. 28, 2018, 9:46 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68550/
> ---
> 
> (Updated Aug. 28, 2018, 9:46 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Greg Mann, 
> and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 997154a8f6c30b7d74ff5e67fb3efa0bc2b94de7 
> 
> 
> Diff: https://reviews.apache.org/r/68550/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

2018-08-28 Thread Alexander Rukletsov



> On Aug. 22, 2018, 2:30 a.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/include/process/statistics.hpp
> > Line 108 (original), 148 (patched)
> > 
> >
> > Whoops? Can you remove this stray from the diff?

Nope, it participates in type resolution : )


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68224/#review207724
---


On Aug. 14, 2018, 12:48 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68224/
> ---
> 
> (Updated Aug. 14, 2018, 12:48 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/statistics.hpp 
> e9f1fc23bf83f92a2e7de94dba0df48272cc3394 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 
> a2a780bf9de018c823b68aa48977fd9fd1b8a064 
> 
> 
> Diff: https://reviews.apache.org/r/68224/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

2018-08-28 Thread Chun-Hung Hsiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68550/
---

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Greg Mann, and 
Jie Yu.


Repository: mesos


Description
---

Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.


Diffs
-

  src/tests/storage_local_resource_provider_tests.cpp 
997154a8f6c30b7d74ff5e67fb3efa0bc2b94de7 


Diff: https://reviews.apache.org/r/68550/diff/1/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

[GitHub] jieyu closed pull request #308: Add Liangyu as contributor.

2018-08-28 Thread GitBox

jieyu closed pull request #308: Add Liangyu as contributor.
URL: https://github.com/apache/mesos/pull/308
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/contributors.yaml b/docs/contributors.yaml
index e58a39a0d0..630ba4b2aa 100755
--- a/docs/contributors.yaml
+++ b/docs/contributors.yaml
@@ -586,6 +586,14 @@
   jira_user: lawrencew
   reviewboard_user: lawrencew
 
+- name: Liangyu Zhao
+  affiliations:
+- {organization: Microsoft}
+  emails:
+- liangyuzhaor...@hotmail.com
+  jira_user: lia...@microsoft.com
+  reviewboard_user: liazha
+
 - name: Lijun Tang
   emails:
 - hercule2...@gmail.com


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 68548: Added allocator benchmark test harness.

2018-08-28 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68548/#review208067
---



PASS: Mesos patch 68548 was successfully built and tested.

Reviews applied: `['68549', '68548']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2253/mesos-review-68548

- Mesos Reviewbot Windows


On Aug. 28, 2018, 12:45 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68548/
> ---
> 
> (Updated Aug. 28, 2018, 12:45 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
> https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new harness allows us to run allocators with different framework and
> agent profiles.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
>   src/tests/hierarchical_allocator_benchmarks.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68548/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

[GitHub] liangyuRain opened a new pull request #308: Add Liangyu as contributor.

2018-08-28 Thread GitBox

liangyuRain opened a new pull request #308: Add Liangyu as contributor.
URL: https://github.com/apache/mesos/pull/308
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-28 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68454/#review208066
---




src/uri/fetchers/docker.cpp
Lines 100 (patched)


Looks like you did this because we use `path::join` to construct URL. I 
think this can be avoided if we just use `strings::join` when constructing url. 
Constructing url using `path::join` does not make sense.



src/uri/fetchers/docker.cpp
Lines 935-937 (patched)


No need for this tmp variable.



src/uri/fetchers/docker.cpp
Lines 982-986 (patched)


Ditto. No need for this tmp variable.


- Jie Yu


On Aug. 25, 2018, 9:57 p.m., Liangyu Zhao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68454/
> ---
> 
> (Updated Aug. 25, 2018, 9:57 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Gilbert Song, 
> Jie Yu, Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-9159
> https://issues.apache.org/jira/browse/MESOS-9159
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> DockerFetcher now fetches both V2S1 and V2S2 manifests to save on
> disk when agent is running on Windows. Linux part of the code in
> agent is unchanged. In addition to fetching from DockerHub,
> DockerFetcher now supports fetching from foreign URLs provided in
> V2S2 Docker image manifest.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.hpp 7a6193dd75dc10846f52cb039f6a162cc8805c16 
>   src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 
> 
> 
> Diff: https://reviews.apache.org/r/68454/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Liangyu Zhao
> 
>

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

2018-08-28 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/#review208065
---



Patch looks great!

Reviews applied: [68321, 68440, 68441, 68442, 68473, 68537]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 28, 2018, 2:02 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68537/
> ---
> 
> (Updated Aug. 28, 2018, 2:02 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit fixes several minor style issues:
>  - Sorted member function declarations of `ReadOnlyHandler`
>alphabetically.
>  - Added notes to remind readers of the fact that requests
>to certain endpoints are batched.
>  - Changed captured variable in `/frameworks` endpoint handler.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005 
>   src/master/readonly_handler.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68537/diff/2/
> 
> 
> Testing
> ---
> 
> Started Internal CI Run (Jenkins Id #4264)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-28 Thread Jie Yu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68355/#review208062
---


Ship it!




Ship It!

- Jie Yu


On Aug. 17, 2018, 3:37 a.m., Sergey Urbanovich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68355/
> ---
> 
> (Updated Aug. 17, 2018, 3:37 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
> https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a veth CNI plugin that is written in bash. It creates a veth
> virtual network pair, one end of the pair will be moved to container
> network namespace.
> 
> The veth CNI plugin uses 203.0.113.0/24 subnet, it is reserved for
> documentation and examples [rfc5737]. The plugin can allocate up to
> 128 veth pairs.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> 63b109bdbc23733aa3d4cdce1de5385ad9933be8 
>   src/tests/environment.cpp 8c6ec5854268d3c497b9671a95768d6a174673c6 
> 
> 
> Diff: https://reviews.apache.org/r/68355/diff/6/
> 
> 
> Testing
> ---
> 
> bin/mesos-tests.sh --verbose 
> --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics" 
> --gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>

59 matches

Mail list logo