Re: Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.

> On Oct. 4, 2018, 6:25 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['68923', '68924']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 68904: Removed version check from libevent dependency tracking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68904/#review209234 --- Ship it! Ship It! - James Peach On Oct. 3, 2018, 1:30 a.m.,

Re: Review Request 68913: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68913/#review209236 --- Ship it! Ship It! - James Peach On Oct. 3, 2018, 4:50 p.m.,

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/#review209240 --- Ship it! Looks good. The only question I have is whether we

Re: Review Request 68813: Added support for `Option` / `Option`.

> On Sept. 23, 2018, 4:31 a.m., Benjamin Bannier wrote: > > I am not convinced we should add this. The alternative of using e.g., an > > `Option` or `Option` seems to not only produce correct > > behavior (even when wrapping a ptr to `const`), but also caution users > > enough that noting

Re: Review Request 68923: Updated 'Docker::inspect()' to avoid 'os::killtree()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209231 --- Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 5:22 a.m., Greg

Re: Review Request 68914: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68914/#review209237 --- Ship it! Ship It! - James Peach On Oct. 3, 2018, 4:51 p.m.,

Re: Review Request 68915: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68915/#review209238 --- Ship it! Ship It! - James Peach On Oct. 3, 2018, 7:32 p.m.,

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/#review209239 --- Ship it! Ship It! - James Peach On Oct. 3, 2018, 7:32 p.m.,

Re: Review Request 68905: Removed version check from libevent dependency tracking from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68905/#review209235 --- Ship it! Ship It! - James Peach On Oct. 3, 2018, 1:31 a.m.,

Re: Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68924/#review209233 --- Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 5:26 a.m., Greg

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/#review209245 --- Ship it! Ship It! - Greg Mann On Oct. 4, 2018, 10:02 a.m.,

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68865/#review209242 --- Ship it! Ship It! - Greg Mann On Oct. 4, 2018, 9:38 a.m.,

Re: Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68924/ --- (Updated Oct. 4, 2018, 10:14 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209246 --- Ship it! Ship It! - Gilbert Song On Oct. 4, 2018, 3:14

Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209247 --- Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 10:14 p.m.,

Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209248 --- PASS: Mesos patch 68923 was successfully built and tested.

Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/ --- Review request for mesos, Greg Mann, Jie Yu, Meng Zhu, Qian Zhang, and Vinod

Re: Review Request 68929: Fixed the nested container launch failure on the agent upgrade case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68929/#review209250 --- PASS: Mesos patch 68929 was successfully built and tested.

Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/ --- (Updated Oct. 4, 2018, 10:14 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/ --- (Updated Oct. 4, 2018, 9:33 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/ --- (Updated Oct. 4, 2018, 9:39 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/ --- (Updated Oct. 4, 2018, 10:02 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/ --- (Updated Oct. 4, 2018, 9:42 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68919/#review209218 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 10:55

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68865/ --- (Updated Oct. 4, 2018, 9:07 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68865/ --- (Updated Oct. 4, 2018, 9:38 a.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 68904: Removed version check from libevent dependency tracking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68904/#review209209 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 3:30

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/#review209211 --- Ship it! Ship It! - Alexander Rojas On Oct. 4, 2018, 1:06

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/#review209215 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 9:32

Re: Review Request 68914: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68914/#review209213 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 6:51

Re: Review Request 68905: Removed version check from libevent dependency tracking from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68905/#review209210 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 3:31

Re: Review Request 68915: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68915/#review209214 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 9:32

Re: Review Request 68913: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68913/#review209212 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 6:50

Re: Review Request 68903: Avoid deadlock-prone blocking in master's parallel endpoint serving.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68903/#review209216 --- src/master/http.cpp Lines 2433-2440 (patched)

Re: Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68924/#review209208 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/#review209219 --- PASS: Mesos patch 68866 was successfully built and tested.